Bug 979572

Summary:	vdsm-reg: rollback network configuration if addNetwork fails
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Alon Bar-Lev <alonbl>
Component:	vdsm	Assignee:	Alon Bar-Lev <alonbl>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.3.0	CC:	acathrow, alonbl, bazulay, danken, hateya, iheim, jkt, lpeer, mpavlik, myakove
Target Milestone:	---	Keywords:	Triaged
Target Release:	3.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	network
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-07-21 14:43:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	979081, 979567, 999123
Bug Blocks:	979570

Description Alon Bar-Lev 2013-06-28 20:17:56 UTC

Continue discussion from bug#979081.

Currently vdsm-bootstrap, host-deploy, vdsm-reg do not rollback network configuration if addNetwork fails.

The sequence should be:
- addNetwork
- vdsm-restore-net-config -> rollback
- vdsm-store-net-config -> commit

vdsm-restore-net-config does not work on ovirt-node/rhev-h, waiting for bug#979567.

Best if we could avoid the bridge module anyway and perform all from engine, including the removal of brXXX bridges, so we do not need to maintain these deviations.

Comment 1 Dan Kenigsberg 2013-07-03 09:19:13 UTC

When is vdsm-reg's makeBridge code used these days? I thought it has been deprecated by ovirt-host-deploy.

If this corner case does not affect the master branch, and lacking customers complaining about this, I would rather not touch the vdsm-reg hornet nest.

Comment 2 Alon Bar-Lev 2013-07-20 00:31:39 UTC

(In reply to Dan Kenigsberg from comment #1)
> When is vdsm-reg's makeBridge code used these days? I thought it has been
> deprecated by ovirt-host-deploy.

vdsm-reg is not deprecated, it should have been replaced by bug#875088, so the logic is intact... as the unfortunate design creates the bridge before it tries to register.

> If this corner case does not affect the master branch, and lacking customers
> complaining about this, I would rather not touch the vdsm-reg hornet nest.

I agree, I opened this bug to get formal approval.

Comment 3 Dan Kenigsberg 2013-07-21 14:43:48 UTC

In this case, I suggest not to solve it. If this becomes urgently needed, and we end up touching vdsm-reg, I prefer to drop bridge creation from it, and let it be solved once in ovirt-host-deploy.

Comment 4 Dan Kenigsberg 2013-09-03 07:22:20 UTC

*** Bug 979081 has been marked as a duplicate of this bug. ***