Spec URL: http://cycloptivity.fedorapeople.org/drupal7-admin_menu.spec SRPM URL: http://cycloptivity.fedorapeople.org/drupal7-admin_menu-3.0-0.1.rc4.fc19.src.rpm Description: Drupal 7 contrib module, Provides a theme-independent administration interface Fedora Account System Username: cycloptivity This is my first package and as such need a sponsor. Latest builds at https://koji.fedoraproject.org/koji/taskinfo?taskID=6817046
Hi Sam, I can sponsor you provided you will review other package submission and/or will add few more package reviews. When you will do any informal package review, please add that review bug number in this bugzilla. This will let me know that you are doing some reviews. also please read the process of getting sponsored in packager group at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group Look for new packages at http://fedoraproject.org/PackageReviewStatus/NEW.html you may also find following links interested to read http://fedoraproject.org/wiki/Using_Fedora_GIT http://fedoraproject.org/wiki/Packaging_tricks http://fedoraproject.org/wiki/How_to_create_an_RPM_package http://fedoraproject.org/wiki/Packaging:ReviewGuidelines http://fedoraproject.org/wiki/Package_Review_Process
Hi Parag, Thanks! I will work through a few reviews and upload a few more drupal7 contrib modules. First off is https://bugzilla.redhat.com/show_bug.cgi?id=1094042#c1 Cheers, Sam
Updated to match guidelines at https://fedoraproject.org/wiki/Packaging:Drupal7 Spec URL: http://cycloptivity.fedorapeople.org/drupal7-admin_menu/3.0-0.2/drupal7-admin_menu.spec SRPM URL: http://cycloptivity.fedorapeople.org/drupal7-admin_menu/3.0-0.2/drupal7-admin_menu-3.0-0.2.rc4.fc19.src.rpm Build output: https://koji.fedoraproject.org/koji/taskinfo?taskID=6820861
Forgot to include the PHP deps. Spec URL: http://cycloptivity.fedorapeople.org/drupal7-admin_menu/3.0-0.3/drupal7-admin_menu.spec SRPM URL: http://cycloptivity.fedorapeople.org/drupal7-admin_menu/3.0-0.3/drupal7-admin_menu-3.0-0.3.rc4.fc19.src.rpm Build output: https://koji.fedoraproject.org/koji/taskinfo?taskID=6824294
Second review at https://bugzilla.redhat.com/show_bug.cgi?id=1094864#c1
Added drupal7-block_class review at https://bugzilla.redhat.com/show_bug.cgi?id=1095593
Review: + Package builds successful in F21 x86_64 mock + rpmlint on generated rpms gave 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as (sha256sum) srpm tarball: 3ca04f52c3d0d53dd37a6b9f9412659ddf3b8453e930c3c82fca25c853da7cc5 upstream tarball : 3ca04f52c3d0d53dd37a6b9f9412659ddf3b8453e930c3c82fca25c853da7cc5 + License is valid GPLv2+ and included in its own text file LICENSE.txt + Package follows drupal7 packaging guidelines Suggestions: 1) Group tag is not necessary in Fedora now and can be removed from spec file. See https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag APPROVED this package review.
Note I have reviewed your packages but do some more full reviews, say 3-5 packages of different types and I will sponsor you then. Only then you can import these reviewed packages in Fedora.
This review bug summary should match with the summary written in spec file.
Hi Sam, Any updates on reviewing other people packages??
(In reply to Parag AN(पराग) from comment #10) > Hi Sam, > Any updates on reviewing other people packages?? Hi Parag, Sorry for the delay! I've posted two more contrib modules. https://bugzilla.redhat.com/show_bug.cgi?id=1099267 https://bugzilla.redhat.com/show_bug.cgi?id=1099269 Cheers, Sam
After initial import, please remove "Requires: php(language) >= 5.1"
*** Bug 1099901 has been marked as a duplicate of this bug. ***
ping any updates?
Spec URL: http://cycloptivity.fedorapeople.org/drupal7-admin_menu.spec SRPM URL: http://cycloptivity.fedorapeople.org/drupal7-admin_menu-3.0-0.1.rc4.fc19.src.rpm Description: Provides a theme-independent administration interface (aka. "navigation", "back-end"). It's a helper for novice users coming from other CMS, a time-saver for site administrators, and useful for developers and site builders. Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7081546 Updated to remove lang reference.
New Package SCM Request ======================= Package Name: drupal7-admin_menu Short Description: Provides a theme-independent administration interface Upstream URL: http://drupal.org/project/admin_menu Owners: cycloptivity anross asrob siwinski Branches: f19 f20 el6 epel7 InitialCC:
hey wait let me first review the updated package then only submit the SCM request.
okay I looked into all above links and found the scratch build link showing correct srpm update but the spec and srpm links above are not correct. I assume its copy/paste error. Based on this I am going to approve this updated srpm in comment 15. Re-APPROVED.
anross is not in the packager group.
Sam, Andrew Ross is not a member of packager group so you may want to remove his ownership request and resubmit request in comment 16.
New Package SCM Request ======================= Package Name: drupal7-admin_menu Short Description: Provides a theme-independent administration interface Upstream URL: http://drupal.org/project/admin_menu Owners: cycloptivity asrob siwinski Branches: f19 f20 el6 epel7 InitialCC:
Git done (by process-git-requests).
drupal7-admin_menu-3.0-0.4.rc4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/drupal7-admin_menu-3.0-0.4.rc4.fc20
drupal7-admin_menu-3.0-0.4.rc4.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/drupal7-admin_menu-3.0-0.4.rc4.el7
drupal7-admin_menu-3.0-0.4.rc4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal7-admin_menu-3.0-0.4.rc4.el6
drupal7-admin_menu-3.0-0.4.rc4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/drupal7-admin_menu-3.0-0.4.rc4.fc19
I got the permission from this package submitter to build his packages. I see this package missed f21 branch please create it. Package Change Request ======================= Package Name: drupal7-admin_menu New Branches: f21 Owners: cycloptivity asrob siwinski
drupal7-admin_menu-3.0-0.4.rc4.el7 has been pushed to the Fedora EPEL 7 testing repository.
drupal7-admin_menu-3.0-0.4.rc4.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/drupal7-admin_menu-3.0-0.4.rc4.fc21
drupal7-admin_menu-3.0-0.4.rc4.fc20 has been pushed to the Fedora 20 stable repository.
drupal7-admin_menu-3.0-0.4.rc4.fc19 has been pushed to the Fedora 19 stable repository.
drupal7-admin_menu-3.0-0.4.rc4.el6 has been pushed to the Fedora EPEL 6 stable repository.
drupal7-admin_menu-3.0-0.4.rc4.el7 has been pushed to the Fedora EPEL 7 stable repository.
drupal7-admin_menu-3.0-0.4.rc4.fc21 has been pushed to the Fedora 21 stable repository.