Bug 1115914 - Add kdump anaconda addon to install image
Summary: Add kdump anaconda addon to install image
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: lorax
Version: 21
Hardware: All
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Brian Lane
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1122752 (view as bug list)
Depends On: 1065674
Blocks: 1116321 1116323 1116331 1116335 1116338 1116340 1116343 1118527 1118529 1176483 1399436
TreeView+ depends on / blocked
 
Reported: 2014-07-03 10:25 UTC by Dave Young
Modified: 2016-11-29 04:49 UTC (History)
9 users (show)

Fixed In Version: lorax-21.19-1
Doc Type: Bug Fix
Doc Text:
Clone Of: 1070558
: 1116335 1118527 1176483 (view as bug list)
Environment:
Last Closed: 2014-11-06 00:33:22 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Comment 1 Dave Young 2014-07-03 10:27:47 UTC
The addon is in kexec-tools package. It's built as a subpackage named:
kexec-tools-anaconda-addon-$(version).rpm

Comment 3 Brian Lane 2014-07-08 17:07:20 UTC
So lorax just needs to include the kexec-tools-anaconda-addon package?

Note that you'll also need to do this for spin-kickstarts if you want it to work from livecd-tools created media.

Comment 4 Dave Young 2014-07-09 03:00:58 UTC
Hi,

(In reply to bcl from comment #3)
> So lorax just needs to include the kexec-tools-anaconda-addon package?
> 

Here is a patch from Vratislav, but it need change to optionally enable the addon with a cmdline param.
http://paste.fedoraproject.org/115269/14043815/

> Note that you'll also need to do this for spin-kickstarts if you want it to
> work from livecd-tools created media.

Could you elaborate how to do this? I know nothing about spin-kickstarts. Per discussion with Vratislav it will be enough for enabling it in lorax..

Thanks
Dave

Comment 5 Brian Lane 2014-07-09 23:09:19 UTC
We can't optionally add packages to the installation media. You can make it optional in Anaconda with a cmdline, but it always has to be present on the boot.iso

Live media is created from spin-kickstarts which maintains a separate list of packages. You need to talk to mattdm about getting it added there.

Comment 6 Dave Young 2014-07-11 00:35:04 UTC
(In reply to bcl from comment #5)
> We can't optionally add packages to the installation media. You can make it
> optional in Anaconda with a cmdline, but it always has to be present on the
> boot.iso

Ok, I got the point. That means we need another anaconda bug.

> 
> Live media is created from spin-kickstarts which maintains a separate list
> of packages. You need to talk to mattdm about getting it added there.

Ok, thanks a lot. Ccing him here.

Dave

Comment 7 Brian Lane 2014-07-23 17:17:30 UTC
I have reverted this change for lorax-21.18-1, the addon was causing anaconda to crash, making it hard for others to make progress. I should have tested it in more detail before I added it to lorax.

In the future can you make sure that an updates.img of your changes don't cause problems with the latest boot.iso before building the new package. Once this is in lorax any problems in the addon will be included in the next boot.iso compose so we need to make sure we catch things before the package is built.

Comment 8 Dave Young 2014-07-24 01:16:14 UTC
(In reply to bcl from comment #7)
> I have reverted this change for lorax-21.18-1, the addon was causing
> anaconda to crash, making it hard for others to make progress. I should have
> tested it in more detail before I added it to lorax.
> 
> In the future can you make sure that an updates.img of your changes don't
> cause problems with the latest boot.iso before building the new package.
> Once this is in lorax any problems in the addon will be included in the next
> boot.iso compose so we need to make sure we catch things before the package
> is built.

Hi, Brian,

Sorry about that. It previously works when we worked on it. I did some test yestoday the addon does not show up. With latest github code there's some problem for startup_id property. It does not work on gtk3. We have a seperate glade file for Fedora in fact you have a patch for original old tree. I have fixed it in github and tested with latest F21 boot.iso. Will update to Fedora ASAP.

BTW, we have added inst.kdump_addon cmdline so that by default the addon does not show unless user specify inst.kdump_addon=on

Thanks
Dave

Comment 9 Dave Young 2014-07-24 01:17:23 UTC
Could you confirm if the crash is caused by startup_id?

Comment 10 David Shea 2014-07-24 02:45:08 UTC
*** Bug 1122752 has been marked as a duplicate of this bug. ***

Comment 11 Dave Young 2014-07-24 06:09:46 UTC
Here is a new build for F21:
http://koji.fedoraproject.org/koji/buildinfo?buildID=547620

Comment 12 Brian Lane 2014-07-25 21:43:06 UTC
Thanks for the quick response. I've tested it against today's boot.iso and everything looks good. I've also talked to clumens and next week he's going to get a test setup for the adding in the anaconda team's jenkins system. I'll re-enable it in the next lorax build.

Comment 13 Vratislav Podzimek 2014-10-13 09:37:17 UTC
(In reply to bcl from comment #12)
> Thanks for the quick response. I've tested it against today's boot.iso and
> everything looks good. I've also talked to clumens and next week he's going
> to get a test setup for the adding in the anaconda team's jenkins system.
> I'll re-enable it in the next lorax build.
Brian, can you please tell me what is the current status of this bug? Is the kdump addon enabled in F21 lorax? I'd like to push changes for bug 1116323 to f21-branch, but I'm not sure I can know.

Comment 14 Brian Lane 2014-11-06 00:33:22 UTC
kdump is now included.


Note You need to log in before you can comment on or make changes to this bug.