Bug 1135105 – Should send data message for file copy of 0 size

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1135105 - Should send data message for file copy of 0 size

Summary:	Should send data message for file copy of 0 size

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Virtualization Manager
Classification:	Red Hat
Component:	mingw-virt-viewer (Show other bugs)
Sub Component:
Version:	3.6.0
Hardware:	Unspecified Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	ovirt-3.6.0-rc
Target Release:	3.6.0
Assigned To:	Default Assignee for SPICE Bugs
QA Contact:	SPICE QE bug list
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:	1135099 1181289
Blocks:
	Show dependency tree / graph

Reported:	2014-08-28 16:07 EDT by Marc-Andre Lureau
Modified:	2016-03-09 15:08 EST (History)
CC List:	15 users (show)

See Also:
Fixed In Version:	mingw-virt-viewer-2.0-1.el7ev
Doc Type:	Bug Fix
Doc Text:	Previously, the SPICE client did not send a data message when transferring zero-sized files by drag and drop. Because the guest agent expects to receive a message, it would keep a file open, causing a leak. This has been fixed by adding a transfer message for zero-sized files to prevent guests from leaking file descriptors in the guest agent during the copy.
Story Points:	---
Clone Of:	1135099
Environment:
Last Closed:	2016-03-09 15:08:59 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	Spice
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHEA-2016:0377	normal	SHIPPED_LIVE	rhevm-spice-client bug fix and enhancement update	2016-03-09 19:39:05 EST

Groups: None (edit)

Description Marc-Andre Lureau 2014-08-28 16:07:51 EDT

+++ This bug was initially created as a clone of Bug #1135099 +++

Description of problem:

spice-gtk doesn't send data message for 0-size files, however both linux and windows agents are expecting to receive it, or they will keep a file open, thus leaking it.

Version-Release number of selected component (if applicable):

any with file copy/xfer support

How reproducible:

100%

Steps to Reproduce:
1. dnd 0-size files to remote desktop

Actual results:

spice-vdagent number of open fd keeps growing

Expected results:

number of fd shouldn't grow.

Comment 1 Marc-Andre Lureau 2014-08-28 16:41:16 EDT

posted http://lists.freedesktop.org/archives/spice-devel/2014-August/017291.html

Comment 3 David Jaša 2015-07-23 06:52:54 EDT

Well-known problem, qa_ack+

Comment 6 Dayle Parker 2016-02-29 19:39:09 EST

If this bug requires doc text for errata release, please provide draft text in the doc text field in the following format:

 Cause:
 Consequence:
 Fix:
 Result:

Comment 7 Tomas Pelka 2016-03-01 04:28:11 EST

I'm sorry Dayle, we as QE are not responsible for filling doc text.

Comment 9 errata-xmlrpc 2016-03-09 15:08:59 EST

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-0377.html

Note You need to log in before you can comment on or make changes to this bug.