Bug 1136916 - [RFE] Add visual element to LUNs already in use by Storage domain in add External (Direct Lun) screen
Summary: [RFE] Add visual element to LUNs already in use by Storage domain in add Exte...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RFEs
Version: ---
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.2.5
: 4.2.5
Assignee: shani
QA Contact: Shir Fishbain
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-03 15:11 UTC by Gilad Lazarovich
Modified: 2019-04-28 09:54 UTC (History)
8 users (show)

Fixed In Version: ovirt-engine-4.2.5
Clone Of:
Environment:
Last Closed: 2018-07-31 15:26:56 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.2?
ebenahar: testing_plan_complete-
ylavi: planning_ack?
rule-engine: devel_ack+
rule-engine: testing_ack+


Attachments (Terms of Use)
LUNs note they belong to a Storage Domain only after clicking on them (76.53 KB, application/octet-stream)
2014-09-03 15:11 UTC, Gilad Lazarovich
no flags Details
Solved issue for identifing external luns. (227.74 KB, image/png)
2018-05-21 12:20 UTC, shani
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 86187 0 None None None 2018-05-25 08:01:31 UTC
oVirt gerrit 92346 0 master MERGED webadmin: AlertPanel instead of a Label in IscsiStorageView 2018-06-19 14:53:22 UTC
oVirt gerrit 92388 0 ovirt-engine-4.2 MERGED webadmin: AlertPanel instead of a Label in IscsiStorageView 2018-06-21 05:10:19 UTC

Description Gilad Lazarovich 2014-09-03 15:11:39 UTC
Created attachment 934134 [details]
LUNs note they belong to a Storage Domain only after clicking on them

Description of problem:
Add visual element to LUNs already in use by Storage domain in add External (Direct Lun) screen.  Currently, you only know that a LUN is already allocated to an existing Storage Domain when clicking on it.  Having the visual element (for example: an asterisk or exclamation) will allow user to skip such LUNs more efficiently.  Note that I've gone through several bugs on this topic: 
BZ #1096904, BZ #980162

How reproducible:
100%

Additional info:
See attached screenshot

Comment 2 Tal Nisan 2018-05-21 09:34:03 UTC
Shani, iirc you handle a similar request in the same dialog, is it the same?

Comment 3 shani 2018-05-21 12:20:24 UTC
Created attachment 1439599 [details]
Solved issue for identifing external luns.

This one was solved as a part of this patch: https://gerrit.ovirt.org/#/c/86187/.

As you can see in the screenshot attached, luns which are already part of other iscsi storage domain have an N/A label on the 'Actions' column and their line is grayed out.

Unlike a lun which is a part of the current (managed) iscsi storage domain, this one has a green V mart on the most left column, and it should be grayed out in case it can't be extended.

Comment 4 Red Hat Bugzilla Rules Engine 2018-05-21 14:53:53 UTC
This request has been proposed for two releases. This is invalid flag usage. The ovirt-future release flag has been cleared. If you wish to change the release flag, you must clear one release flag and then set the other release flag to ?.

Comment 5 RHV bug bot 2018-05-24 23:52:59 UTC
INFO: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[No external trackers attached]

For more info please contact: infra

Comment 6 Sandro Bonazzola 2018-05-25 08:03:20 UTC
(In reply to shani from comment #3)
> Created attachment 1439599 [details]
> Solved issue for identifing external luns.
> 
> This one was solved as a part of this patch:
> https://gerrit.ovirt.org/#/c/86187/.

the referenced patch has been included in ovirt-engine-4.2.1.2.
Moving to QE.

Comment 7 Shir Fishbain 2018-06-11 12:18:34 UTC
If the addition of visual element to LUNs is for a new virtual disk? 
Because it doesn't appear there but only in manage domain.

Comment 9 shani 2018-06-13 10:17:53 UTC
You are right, I'll work on a patch fixing it.
Moving back to assigned.

Thanks!

Comment 10 shani 2018-06-13 14:30:08 UTC
This issue was discussed before here [1], and it seems that this operation should not be blocked (i.e., not block the ability to create a direct lun disk over a lun which already in use).

[1] https://bugzilla.redhat.com/show_bug.cgi?id=980162

Therefore, moving back to on_qa

Comment 11 Shir Fishbain 2018-06-18 08:12:50 UTC
We didn't claim the operation of adding LUN that is part of a domain should be blocked.
The issue is that this bug was reported on the add direct LUN prompt and the fix is on manage domains prompt.

Comment 12 shani 2018-06-19 08:36:40 UTC
After a f2f talk, the current patch was suggested.

Comment 13 Shir Fishbain 2018-07-05 15:40:37 UTC
The comment:"LUN is already part of a Storage Domain: iscsi_0" is highlighted with an exclamation mark. 

4.2.5-0.1.el7ev

Comment 14 Sandro Bonazzola 2018-07-31 15:26:56 UTC
This bugzilla is included in oVirt 4.2.5 release, published on July 30th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.