Bug 980162 - configuring direct-lun using lun which is already part of SD should be notified
Summary: configuring direct-lun using lun which is already part of SD should be notified
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: 3.4.0
Assignee: Tal Nisan
QA Contact: Aharon Canan
URL:
Whiteboard: storage
: 879293 1096904 (view as bug list)
Depends On:
Blocks: 889053 910990 977679 977681
TreeView+ depends on / blocked
 
Reported: 2013-07-01 14:55 UTC by Aharon Canan
Modified: 2016-02-10 19:11 UTC (History)
13 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-09 16:26:44 UTC
oVirt Team: Storage
Target Upstream Version:
Embargoed:
scohen: needinfo+


Attachments (Terms of Use)
screenshot (102.63 KB, image/png)
2013-12-04 14:23 UTC, Elad
no flags Details

Description Aharon Canan 2013-07-01 14:55:55 UTC
Description of problem:
=======================
engine should not allow user to use used luns within the same engine for creation of new disk or storage domain

Version-Release number of selected component (if applicable):
=============================================================
3.2


How reproducible:
=================
100%

Steps to Reproduce:
===================
1. Create new VM
2. attached direct-lun disk (Disk should be already in use by another storage domain) to that VM - 
3. start the VM

Actual results:
===============
able to attached direct-lun, cause data corruption

Expected results:
=================
user shouldn't be able to attached disk that already part of another storage domain

Additional info:

Comment 1 Itamar Heim 2013-07-02 08:41:16 UTC
not sure we should/can block this for now - ManageIQ (CloudForms) and other vendors are using this technique to analyze the disks on storage today.

Comment 3 Allon Mureinik 2013-12-03 10:30:38 UTC
Is this via the webadmin? REST? 
Can we get a log? screenshot?

Comment 4 Elad 2013-12-04 14:23:28 UTC
Created attachment 832683 [details]
screenshot

Allon,
Check on webadmin,
We get a red warning on the disk creation window when we pick a LUN which is already part of a SD.

Attaching screenshot

Comment 5 Allon Mureinik 2013-12-04 15:01:15 UTC
AFAIK, Itamar is correct (see comment 1) - ManageIQ needs this feature, so we can only warn about it, not block the operation.

Sean, can you confirm?

Comment 6 Sean Cohen 2013-12-08 08:45:55 UTC
(In reply to Allon Mureinik from comment #5)
> AFAIK, Itamar is correct (see comment 1) - ManageIQ needs this feature, so
> we can only warn about it, not block the operation.
> 
> Sean, can you confirm?

Confirmed, this operation should not be blocked. Cloudforms & other clusters solutions require it today,
However, we can notify the user that the direct LUN is already used in another VM and ask user to confirm the operation.
Changing the bug title accordingly
Sean

Comment 7 Allon Mureinik 2013-12-09 16:26:44 UTC
The warning is already there (see snapshot), and the operation should not be blocked (see comment 6).
Based on these inputs, I'm closing the bug.

Comment 8 Daniel Erez 2013-12-23 13:24:55 UTC
*** Bug 879293 has been marked as a duplicate of this bug. ***

Comment 9 Daniel Erez 2014-05-12 22:23:14 UTC
*** Bug 1096904 has been marked as a duplicate of this bug. ***

Comment 10 Nicolas Ecarnot 2015-04-09 14:20:18 UTC
Before trying to do the same thing (ie. direct attach to a LUN), to try to follow the doc here (http://manageiq.org/documentation/top-tasks/#run-smartstate-analysis-on-rhev-m-virtual-machines), is it harmless to do so?

Is it recommended to attach it with read only checkbox checked?

Comment 11 Allon Mureinik 2015-04-09 14:39:41 UTC
(In reply to Nicolas Ecarnot from comment #10)
> Before trying to do the same thing (ie. direct attach to a LUN), to try to
> follow the doc here
> (http://manageiq.org/documentation/top-tasks/#run-smartstate-analysis-on-
> rhev-m-virtual-machines), is it harmless to do so?
> 
> Is it recommended to attach it with read only checkbox checked?

SmartState analysis is perfectly safe.
I'm not an expert on the details, but using read-only sounds like a good idea.


Note You need to log in before you can comment on or make changes to this bug.