Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1171703

Summary: AFR+SNAPSHOT: File with hard link have different inode number in USS
Product: [Community] GlusterFS Reporter: Vijaikumar Mallikarjuna <vmallika>
Component: snapshotAssignee: Manikandan <mselvaga>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: urgent Docs Contact:
Priority: unspecified    
Version: mainlineCC: ashah, asriram, bugs, rhinduja, rjoseph, smohan
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: USS
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Currently we generate virtual gfid for all the files under the directory.snaps. If there are hard links, each file for this hardlink are assigned separate gfids and hence different inode number.
Story Points: ---
Clone Of: 1170365
: 1316099 (view as bug list) Environment:
Last Closed: 2016-06-16 12:40:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1170365, 1303591    
Bug Blocks: 1316099    

Comment 1 Anand Avati 2014-12-08 12:46:21 UTC
REVIEW: http://review.gluster.org/9255 (uss/gluster: generate gfid for snapshot files from an inode num and snapshot gfid) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 2 Anand Avati 2014-12-08 16:17:05 UTC
REVIEW: http://review.gluster.org/9255 (uss/gluster: generate gfid for snapshot files from an inode num and snapshot gfid) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 3 Anand Avati 2014-12-08 16:19:56 UTC
REVIEW: http://review.gluster.org/9255 (uss/gluster: generate gfid for snapshot files from an inode num and snapshot gfid) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 4 Anand Avati 2014-12-08 18:28:34 UTC
REVIEW: http://review.gluster.org/9255 (uss/gluster: generate gfid for snapshot files from an inode num and snapshot gfid) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 5 Anand Avati 2014-12-09 03:38:25 UTC
REVIEW: http://review.gluster.org/9255 (uss/gluster: generate gfid for snapshot files from an inode num and snapshot gfid) posted (#5) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 6 Pavithra 2014-12-09 06:11:05 UTC
Hi Vijai,

I see this bug added as a known issue in the known issues tracker bug(1153907) for the 3.0.3 release. Can you please change the doc type to known issue and add the doc text?

Comment 7 Anand Avati 2014-12-09 19:04:47 UTC
REVIEW: http://review.gluster.org/9255 (uss/gluster: generate gfid for snapshot files from an inode num and snapshot gfid) posted (#6) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 8 Anand Avati 2014-12-10 03:44:28 UTC
REVIEW: http://review.gluster.org/9255 (uss/gluster: generate gfid for snapshot files from an inode num and snapshot gfid) posted (#7) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 9 Vijay Bellur 2016-02-01 07:08:52 UTC
REVIEW: http://review.gluster.org/9255 (uss/gluster: generate gfid for snapshot files from snapname and gfid) posted (#8) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 10 Vijay Bellur 2016-02-01 11:41:44 UTC
REVIEW: http://review.gluster.org/9255 (uss/gluster: generate gfid for snapshot files from snapname and gfid) posted (#9) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 11 Vijay Bellur 2016-02-01 11:45:54 UTC
REVIEW: http://review.gluster.org/9255 (uss/gluster: generate gfid for snapshot files from snapname and gfid) posted (#10) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 12 Vijay Bellur 2016-02-09 10:14:05 UTC
REVIEW: http://review.gluster.org/9255 (uss/gluster: generate gfid for snapshot files from snapname and gfid) posted (#11) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 13 Vijay Bellur 2016-02-09 10:20:37 UTC
REVIEW: http://review.gluster.org/9255 (uss/gluster: generate gfid for snapshot files from snapname and gfid) posted (#12) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 14 Vijay Bellur 2016-02-09 10:39:40 UTC
REVIEW: http://review.gluster.org/9255 (uss/gluster: generate gfid for snapshot files from snapname and gfid) posted (#13) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 15 Vijay Bellur 2016-02-09 10:40:42 UTC
REVIEW: http://review.gluster.org/9255 (uss/gluster: generate gfid for snapshot files from snapname and gfid) posted (#14) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 16 Vijay Bellur 2016-02-10 01:10:52 UTC
REVIEW: http://review.gluster.org/9255 (uss/gluster: generate gfid for snapshot files from snapname and gfid) posted (#15) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 17 Vijay Bellur 2016-03-10 10:43:29 UTC
COMMIT: http://review.gluster.org/9255 committed in master by Rajesh Joseph (rjoseph) 
------
commit e0f71288d95469d7ae82473ef273c6ba43250a36
Author: vmallika <vmallika>
Date:   Wed Feb 10 06:39:22 2016 +0530

    uss/gluster: generate gfid for snapshot files from snapname and gfid
    
    If 'a' and 'b' are hardlinks, we need to generate a virtual
    gfid for these files so that the inode number for 'a' and 'b'
    are same.
    
    Generate gfid as below:
    gfid_of_a = MD5(snapname + back_end_gfid(a))
    if '/dir1/a' and '/dir2/b' are hardlinks, then inode number should be
    same for
    all below files:
    /mnt/.snaps/snap1/dir1/a
    /mnt/.snaps/snap1/dir2/b
    /mnt/dir1/.snaps/snap1/a
    /mnt/dir2/.snaps/snap1/b
    
    Change-Id: Ifda793455610e554f3f1e4cbb90d44c02cda4b0f
    BUG: 1171703
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/9255
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Rajesh Joseph <rjoseph>

Comment 20 Niels de Vos 2016-06-16 12:40:24 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user