Bug 1176895 - Review Request: nodejs-compress-commons - A library that defines a common interface for working with archive formats
Summary: Review Request: nodejs-compress-commons - A library that defines a common int...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1176887 1176893
Blocks: 1176896
TreeView+ depends on / blocked
 
Reported: 2014-12-23 14:53 UTC by Piotr Popieluch
Modified: 2015-01-24 18:48 UTC (History)
2 users (show)

Fixed In Version: nodejs-compress-commons-0.2.0-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-31 18:18:45 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Piotr Popieluch 2014-12-23 14:53:22 UTC
Spec URL: https://piotrp.fedorapeople.org/nodejs-compress-commons.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-compress-commons-0.2.0-1.fc21.src.rpm
Description: 
Compress Commons is a library that defines a common interface for working with
archive formats within node.
Fedora Account System Username: piotrp

Comment 1 Parag AN(पराग) 2014-12-23 17:19:00 UTC
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-compress-commons.noarch: W: only-non-binary-in-usr-lib
nodejs-compress-commons.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/nodejs-compress-commons/README.md
nodejs-compress-commons.noarch: W: dangling-symlink /usr/lib/node_modules/compress-commons/node_modules/readable-stream /usr/lib/node_modules/readable-stream
nodejs-compress-commons.noarch: W: dangling-symlink /usr/lib/node_modules/compress-commons/node_modules/node-int64 /usr/lib/node_modules/node-int64
nodejs-compress-commons.noarch: W: dangling-symlink /usr/lib/node_modules/compress-commons/node_modules/crc32-stream /usr/lib/node_modules/crc32-stream
nodejs-compress-commons.noarch: W: dangling-symlink /usr/lib/node_modules/compress-commons/node_modules/buffer-crc32 /usr/lib/node_modules/buffer-crc32
nodejs-compress-commons.src: W: strange-permission nodejs-compress-commons-dl-tests.sh 0755L
nodejs-compress-commons.src: W: invalid-url Source1: nodejs-node-compress-commons-tests-0.2.0.tar.bz2
2 packages and 0 specfiles checked; 0 errors, 8 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball:  ba0b779a52bc3fc850cb9e8c0de373c4afec87565cd51f476038c6ea6abdd517
upstream tarball:   ba0b779a52bc3fc850cb9e8c0de373c4afec87565cd51f476038c6ea6abdd517

+ License is "MIT" and included in its own LICENSE-MIT file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Fix rpmlint warning wrong-file-end-of-line-encoding

APPROVED.

Comment 2 Piotr Popieluch 2014-12-24 10:36:35 UTC
Fixed EOL warning.

New Package SCM Request
=======================
Package Name: nodejs-compress-commons
Short Description: A library that defines a common interface for working with archive formats
Upstream URL: 
Owners: piotrp
Branches: f20 f21 el6 epel7

Comment 3 Piotr Popieluch 2014-12-24 10:42:12 UTC
New Package SCM Request
=======================
Package Name: nodejs-compress-commons
Short Description: A library that defines a common interface for working with archive formats
Upstream URL: https://github.com/ctalkington/node-compress-commons
Owners: piotrp
Branches: f20 f21 el6 epel7

Comment 4 Gwyn Ciesla 2014-12-24 11:29:03 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2014-12-26 21:07:29 UTC
nodejs-compress-commons-0.2.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-compress-commons-0.2.0-1.fc20

Comment 6 Fedora Update System 2014-12-26 21:09:20 UTC
nodejs-compress-commons-0.2.0-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-compress-commons-0.2.0-1.fc21

Comment 7 Fedora Update System 2014-12-27 20:29:11 UTC
nodejs-compress-commons-0.2.0-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-compress-commons-0.2.0-1.el7

Comment 8 Fedora Update System 2014-12-28 20:44:25 UTC
nodejs-compress-commons-0.2.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 9 Piotr Popieluch 2014-12-31 18:18:45 UTC
package built, closing.

Comment 10 Fedora Update System 2015-01-06 06:10:50 UTC
nodejs-compress-commons-0.2.0-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 11 Fedora Update System 2015-01-06 06:12:14 UTC
nodejs-compress-commons-0.2.0-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 12 Fedora Update System 2015-01-24 18:48:47 UTC
nodejs-compress-commons-0.2.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.