Bug 1176896 - Review Request: nodejs-zip-stream - A streaming zip archive generator
Summary: Review Request: nodejs-zip-stream - A streaming zip archive generator
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1176895
Blocks: 1177550
TreeView+ depends on / blocked
 
Reported: 2014-12-23 14:55 UTC by Piotr Popieluch
Modified: 2015-01-24 18:43 UTC (History)
2 users (show)

Fixed In Version: nodejs-zip-stream-0.5.0-1.el7
Clone Of:
Environment:
Last Closed: 2014-12-31 18:01:22 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Piotr Popieluch 2014-12-23 14:55:43 UTC
Spec URL: https://piotrp.fedorapeople.org/nodejs-zip-stream.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-zip-stream-0.5.0-1.fc21.src.rpm
Description: 
zip-stream is a streaming zip archive generator based on the
ZipArchiveOutputStream prototype found in the compress-commons project.
Fedora Account System Username: piotrp

Comment 1 Parag AN(पराग) 2014-12-23 17:18:57 UTC
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-zip-stream.noarch: W: only-non-binary-in-usr-lib
nodejs-zip-stream.noarch: W: dangling-symlink /usr/lib/node_modules/zip-stream/node_modules/compress-commons /usr/lib/node_modules/compress-commons
nodejs-zip-stream.noarch: W: dangling-symlink /usr/lib/node_modules/zip-stream/node_modules/readable-stream /usr/lib/node_modules/readable-stream
nodejs-zip-stream.noarch: W: dangling-symlink /usr/lib/node_modules/zip-stream/node_modules/lodash /usr/lib/node_modules/lodash
nodejs-zip-stream.src: W: strange-permission nodejs-zip-stream-dl-tests.sh 0755L
nodejs-zip-stream.src: W: invalid-url Source1: nodejs-zip-stream-tests-0.5.0.tar.bz2


+ Source verified with upstream as (sha256sum)
srpm tarball:  c9cedcde5485b444722dd155c9d30941114acdc4c9a9836b67e66aad7d2c4823
upstream tarball:  c9cedcde5485b444722dd155c9d30941114acdc4c9a9836b67e66aad7d2c4823 

+ License is "MIT" and included in its own LICENSE-MIT file.

+ follows nodejs packaging guidelines.

APPROVED.

Comment 2 Piotr Popieluch 2014-12-24 10:34:40 UTC
New Package SCM Request
=======================
Package Name: nodejs-zip-stream
Short Description: A streaming zip archive generator
Upstream URL: https://github.com/ctalkington/node-zip-stream
Owners: piotrp
Branches: f20 f21 el6 epel7

Comment 3 Gwyn Ciesla 2014-12-24 11:38:29 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2014-12-26 22:15:10 UTC
nodejs-zip-stream-0.5.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-zip-stream-0.5.0-1.fc20

Comment 5 Fedora Update System 2014-12-26 22:15:51 UTC
nodejs-zip-stream-0.5.0-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-zip-stream-0.5.0-1.fc21

Comment 6 Fedora Update System 2014-12-28 10:13:04 UTC
nodejs-zip-stream-0.5.0-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-zip-stream-0.5.0-1.el7

Comment 7 Fedora Update System 2014-12-28 20:44:36 UTC
nodejs-zip-stream-0.5.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 8 Piotr Popieluch 2014-12-31 18:01:22 UTC
package built, closing.

Comment 9 Fedora Update System 2015-01-06 06:05:20 UTC
nodejs-zip-stream-0.5.0-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 10 Fedora Update System 2015-01-06 06:07:04 UTC
nodejs-zip-stream-0.5.0-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 11 Fedora Update System 2015-01-24 18:43:24 UTC
nodejs-zip-stream-0.5.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.