Bug 1216120 - [abrt] meld: meldapp.py:278:parse_args:UnboundLocalError: local variable 'args' referenced before assignment
Summary: [abrt] meld: meldapp.py:278:parse_args:UnboundLocalError: local variable 'arg...
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: meld
Version: 23
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dominic Hopf
QA Contact: Fedora Extras Quality Assurance
URL: https://retrace.fedoraproject.org/faf...
Whiteboard: abrt_hash:463b4a1c13ea26335407dfacec2...
: 1252882 1304297 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-28 14:14 UTC by Martin Kolman
Modified: 2017-01-02 07:07 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-12-20 13:36:43 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (2.29 KB, text/plain)
2015-04-28 14:14 UTC, Martin Kolman
no flags Details
File: environ (3.59 KB, text/plain)
2015-04-28 14:14 UTC, Martin Kolman
no flags Details

Description Martin Kolman 2015-04-28 14:14:22 UTC
Description of problem:
I've used Meld via "git mergetool". It showed a white screen, so I closed it. After closing it it spit out a traceback and launched again, this time working normally.

Version-Release number of selected component:
meld-3.13.0-2.fc22

Additional info:
reporter:       libreport-2.5.1
cmdline:        /usr/bin/python /usr/bin/meld --help
executable:     /usr/bin/meld
kernel:         4.0.0-0.rc5.git4.1.fc22.x86_64
runlevel:       N 5
type:           Python
uid:            1000

Truncated backtrace:
meldapp.py:278:parse_args:UnboundLocalError: local variable 'args' referenced before assignment

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/meld/meldapp.py", line 73, in do_command_line
    tab = self.parse_args(command_line)
  File "/usr/lib/python2.7/site-packages/meld/meldapp.py", line 278, in parse_args
    if len(args) > 3:
UnboundLocalError: local variable 'args' referenced before assignment

Local variables in innermost frame:
usages: [('', u'Spustit s pr\xe1zdn\xfdm oknem'), (u'<soubor|slo\u017eka>', u'Spustit nov\xe9 porovn\xe1n\xed spr\xe1vy verz\xed'), (u'<soubor> <soubor> [<soubor>]', u'Spustit dvojcestn\xe9 nebo trojcestn\xe9 porovn\xe1n\xed soubor\u016f'), (u'<slo\u017eka> <slo\u017eka> [<slo\u017eka>]', u'Spustit dvojcestn\xe9 nebo trojcestn\xe9 porovn\xe1n\xed slo\u017eek')]
self: <MeldApp object at 0x7ff541f8baf0 (meld+meldapp+MeldApp at 0x1c38270)>
parser: <meld.meldapp.GLibFriendlyOptionParser instance at 0x7ff5404494d0>
command_line: <ApplicationCommandLine object at 0x7ff5404e7370 (GApplicationCommandLine at 0x2020c40)>
s: (u'<slo\u017eka> <slo\u017eka> [<slo\u017eka>]', u'Spustit dvojcestn\xe9 nebo trojcestn\xe9 porovn\xe1n\xed slo\u017eek')
rawargs: ['--help']
cleanup: <function cleanup at 0x7ff5404431b8>
u: (u'<slo\u017eka> <slo\u017eka> [<slo\u017eka>]', u'Spustit dvojcestn\xe9 nebo trojcestn\xe9 porovn\xe1n\xed slo\u017eek')
usage: u'\n  %prog                              Spustit s pr\xe1zdn\xfdm oknem\n  %prog <soubor|slo\u017eka>              Spustit nov\xe9 porovn\xe1n\xed spr\xe1vy verz\xed\n  %prog <soubor> <soubor> [<soubor>] Spustit dvojcestn\xe9 nebo trojcestn\xe9 porovn\xe1n\xed soubor\u016f\n  %prog <slo\u017eka> <slo\u017eka> [<slo\u017eka>] Spustit dvojcestn\xe9 nebo trojcestn\xe9 porovn\xe1n\xed slo\u017eek'
usage_lines: [u'  %prog                              Spustit s pr\xe1zdn\xfdm oknem', u'  %prog <soubor|slo\u017eka>              Spustit nov\xe9 porovn\xe1n\xed spr\xe1vy verz\xed', u'  %prog <soubor> <soubor> [<soubor>] Spustit dvojcestn\xe9 nebo trojcestn\xe9 porovn\xe1n\xed soubor\u016f', u'  %prog <slo\u017eka> <slo\u017eka> [<slo\u017eka>] Spustit dvojcestn\xe9 nebo trojcestn\xe9 porovn\xe1n\xed slo\u017eek']
GLibFriendlyOptionParser: <class meld.meldapp.GLibFriendlyOptionParser at 0x7ff54043fa78>
pad_args_fmt: '%-28s %s'

Comment 1 Martin Kolman 2015-04-28 14:14:26 UTC
Created attachment 1019694 [details]
File: backtrace

Comment 2 Martin Kolman 2015-04-28 14:14:27 UTC
Created attachment 1019695 [details]
File: environ

Comment 3 kealthou 2015-06-13 23:08:10 UTC
A reproducible step is:
1. LANG=cs meld --help

LANG=ja reproduces it too.

A workaround for git mergetool is:
git config mergetool.meld.hasOutput true

Comment 4 Dominic Hopf 2015-09-08 21:28:19 UTC
*** Bug 1252882 has been marked as a duplicate of this bug. ***

Comment 5 Lukáš Doktor 2015-10-06 11:30:39 UTC
Hello guys,

any progress on this one? It's quite annoying and still present in

LANG=cs meld-3.14.0-1.fc22.noarch

Regards,
Lukáš

Comment 6 Lukáš Doktor 2015-10-13 11:13:56 UTC
I tried the latest version from sources https://github.com/GNOME/meld/commit/00b8efe0b1e6c38a3fadf7c9742e647925c1c055 and it works fine. Would it be possible to get the correct version in fedora?

Comment 7 Dominic Hopf 2016-03-13 14:35:16 UTC
This issue should be fixed then, right? There should be at least 3.14.1 in F22 currently.

Comment 8 Lukáš Doktor 2016-03-29 14:50:43 UTC
After "dnf update" on F23 I have meld-3.14.0-2.fc23.noarch and the issue still exists:

```
$ LANG=cs meld --help
Couldn't set the locale: unsupported locale setting; falling back to 'C' locale

(process:20075): Gtk-WARNING **: Locale not supported by C library.
        Using the fallback 'C' locale.
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/meld/meldapp.py", line 72, in do_command_line
    tab = self.parse_args(command_line)
  File "/usr/lib/python2.7/site-packages/meld/meldapp.py", line 277, in parse_args
    if len(args) > 3:
UnboundLocalError: local variable 'args' referenced before assignment
```

as well as "git mergetool" simply hangs without any message, while "LANG=C git mergetool" lunches meld.

```
$ git mergetool
Merging:
README.rst

Normal merge conflict for 'README.rst':
  {local}: modified file
  {remote}: modified file
```

I tried the upstream version https://github.com/GNOME/meld/commit/bd7d1339c6b540130f93166238b18693528c06b5 and it worked well. I wanted to bisect it but all tagged versions worked for me. I tried to loop through all commits and all of them up to the end of the year 2014 worked well. I'm wondering what extra patches the "rpm" version contains...

Comment 9 Lukáš Doktor 2016-03-29 14:53:18 UTC
(In reply to Lukas Doktor from comment #8)
> After "dnf update" on F23 I have meld-3.14.0-2.fc23.noarch and the issue
> still exists:
> 
> ```
> $ LANG=cs meld --help
I mean LANG=cs_CZ meld --help

> Couldn't set the locale: unsupported locale setting; falling back to 'C'
> locale
> 
> (process:20075): Gtk-WARNING **: Locale not supported by C library.
>         Using the fallback 'C' locale.
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/site-packages/meld/meldapp.py", line 72, in
> do_command_line
>     tab = self.parse_args(command_line)
>   File "/usr/lib/python2.7/site-packages/meld/meldapp.py", line 277, in
> parse_args
>     if len(args) > 3:
> UnboundLocalError: local variable 'args' referenced before assignment
> ```
> 
> as well as "git mergetool" simply hangs without any message, while "LANG=C
> git mergetool" lunches meld.
> 
> ```
> $ git mergetool
> Merging:
> README.rst
> 
> Normal merge conflict for 'README.rst':
>   {local}: modified file
>   {remote}: modified file
> ```
> 
> I tried the upstream version
> https://github.com/GNOME/meld/commit/
> bd7d1339c6b540130f93166238b18693528c06b5 and it worked well. I wanted to
> bisect it but all tagged versions worked for me. I tried to loop through all
> commits and all of them up to the end of the year 2014 worked well. I'm
> wondering what extra patches the "rpm" version contains...

Comment 10 Jaroslav Škarvada 2016-03-29 15:26:35 UTC
(In reply to Lukas Doktor from comment #9)
> (In reply to Lukas Doktor from comment #8)
> > After "dnf update" on F23 I have meld-3.14.0-2.fc23.noarch and the issue
> > still exists:
> > 
> > ```
> > $ LANG=cs meld --help
> I mean LANG=cs_CZ meld --help
>
It works for me with:
meld-3.14.1-1.fc23.noarch

Comment 11 Pavel Alexeev 2016-05-04 08:31:28 UTC
*** Bug 1304297 has been marked as a duplicate of this bug. ***

Comment 12 Pavel Alexeev 2016-05-04 08:40:56 UTC
Jaroslav, where you got it? I do not see that version in updates.

Comment 13 Jaroslav Škarvada 2016-05-04 13:04:18 UTC
(In reply to Pavel Alexeev from comment #12)
> Jaroslav, where you got it? I do not see that version in updates.

Hmm interesting, it seems that meld-3.14.1-1.fc23.noarch never got to updates and the koji build was deleted:
http://koji.fedoraproject.org/koji/buildinfo?buildID=689797

But it is in the dist-git:
http://pkgs.fedoraproject.org/cgit/rpms/meld.git/log/?h=f23

which is really weird.

Dominic could you build it and release it as an update?

Comment 14 Fedora End Of Life 2016-11-24 11:44:39 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 15 Fedora End Of Life 2016-12-20 13:36:43 UTC
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 16 Lukáš Doktor 2017-01-02 07:07:37 UTC
Hello guys, I already moved to Fedora 25, where meld works well out of the box.


Note You need to log in before you can comment on or make changes to this bug.