Bug 1221868
| Summary: | Remove iscsi_helper calls from base iscsi driver | |||
|---|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Jaison Raju <jraju> | |
| Component: | openstack-cinder | Assignee: | Gorka Eguileor <geguileo> | |
| Status: | CLOSED ERRATA | QA Contact: | lkuchlan <lkuchlan> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | high | |||
| Version: | 5.0 (RHEL 7) | CC: | ddomingo, dmaley, eharney, geguileo, jraju, jschluet, nlevinki, scohen, sgordon, sgotliv, yeylon | |
| Target Milestone: | z5 | Keywords: | ZStream | |
| Target Release: | 5.0 (RHEL 7) | Flags: | eharney:
internal-review+
|
|
| Hardware: | All | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | openstack-cinder-2014.1.4-6.el7ost | Doc Type: | Bug Fix | |
| Doc Text: |
Previous versions of the iSCSI base driver contained target helper calls that were inappropriate for some drivers. These calls could cause attachment failures on some back ends.
This update moves those target helper calls to the right place, thereby avoiding any unexpected attachment failures.
|
Story Points: | --- | |
| Clone Of: | ||||
| : | 1222108 1254756 (view as bug list) | Environment: | ||
| Last Closed: | 2015-09-10 11:48:37 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1236633 | |||
| Bug Blocks: | 1222108, 1254756 | |||
|
Description
Jaison Raju
2015-05-15 05:42:33 UTC
Gorka, Please, provide a link to your upstream and downstream patches. The fix here introduced other LIO problems (see bug 1236633). Will fix that up with this build. *** Bug 1236633 has been marked as a duplicate of this bug. *** We don't have solidfire storage so the only thing I can do is verify the fix is in
1)vi /usr/lib/python2.7/site-packages/cinder/volume/drivers/lvm.py
def initialize_connection(self, volume, connector):
530 """Initializes the connection and returns connection info."""
531
532 # We have a special case for lioadm here, that's fine, we can
533 # keep the call in the parent class (driver:ISCSIDriver) generic
534 # and still use it throughout, just override and call super here
535 # no duplication, same effect but doesn't break things
536 # see bug: #1400804
537 if self.configuration.iscsi_helper == 'lioadm':
538 self.target_helper.initialize_connection(volume, connector)
539 return super(LVMISCSIDriver, self).initialize_connection(volume,
2)vi /usr/lib/python2.7/site-packages/cinder/volume/driver.py
def get_target_helper(self, db):
841 root_helper = utils.get_root_helper()
842 # FIXME(jdg): These work because the driver will overide
843 # but we need to move these to use self.configuraiton
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-1758.html |