Bug 1223798 - Quota: spurious failures with quota testcases
Summary: Quota: spurious failures with quota testcases
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: quota
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vijaikumar Mallikarjuna
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1226157
TreeView+ depends on / blocked
 
Reported: 2015-05-21 13:06 UTC by Vijaikumar Mallikarjuna
Modified: 2016-06-16 13:03 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1224894 1226157 (view as bug list)
Environment:
Last Closed: 2016-06-16 13:03:49 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Vijaikumar Mallikarjuna 2015-05-21 13:06:39 UTC
Some of the below test cases spuriously failing.
./tests/bugs/distribute/bug-1161156.t
./tests/bugs/quota/bug-1038598.t


Problem is quota enforcer doesn't consider parallel writes and fail to send EDQUOT and allow to exceed quota with few %.


For now, with this patch we fix the testcases not to send parallel writes.
Bug# 1223658 tracks the parallel write issue with quota.

Comment 1 Anand Avati 2015-05-21 13:13:26 UTC
REVIEW: http://review.gluster.org/10878 (Quota: fix testcases not to send parallel writes for accurate quota enforcement) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 2 Anand Avati 2015-05-22 02:20:14 UTC
REVIEW: http://review.gluster.org/10878 (Quota: fix testcases not to send parallel writes for accurate quota enforcement) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 3 Anand Avati 2015-05-25 08:09:00 UTC
REVIEW: http://review.gluster.org/10878 (Quota: fix testcases not to send parallel writes for accurate quota enforcement) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 4 Anand Avati 2015-05-25 08:16:42 UTC
REVIEW: http://review.gluster.org/10878 (Quota: fix testcases not to send parallel writes for accurate quota enforcement) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 5 Anand Avati 2015-05-25 18:34:28 UTC
COMMIT: http://review.gluster.org/10878 committed in master by Raghavendra G (rgowdapp) 
------
commit 225ff553106396066d68d8c757e5c001f5d9ab15
Author: vmallika <vmallika>
Date:   Mon May 25 13:35:48 2015 +0530

    Quota: fix testcases not to send parallel writes for accurate
    quota enforcement
    
    Currently quota enforcer doesn't consider parallel writes
    and allows quota to exceed limit where there are high rate
    of parallel writes. Bug# 1223658 tracks the issue.
    
    This patch fixes the spurious failures by not sending
    parallel writes.
    Using O_SYNC and O_APPEND flags and block size
    not more that 256k (For higher block size NFS client
    splits the block into 256k chinks and does parallel writes)
    
    Change-Id: I297c164b030cecb87ce5b494c02b09e8b073b276
    BUG: 1223798
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/10878
    Tested-by: NetBSD Build System
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>
    Tested-by: Raghavendra G <rgowdapp>

Comment 6 Anand Avati 2015-05-26 10:21:00 UTC
REVIEW: http://review.gluster.org/10918 (quota: fix for spurious failure) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 7 Anand Avati 2015-05-27 06:47:52 UTC
REVIEW: http://review.gluster.org/10918 (quota: fix for spurious failure) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 8 Anand Avati 2015-05-27 10:35:40 UTC
REVIEW: http://review.gluster.org/10918 (quota: fix for spurious failure) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 9 Anand Avati 2015-05-27 11:01:26 UTC
REVIEW: http://review.gluster.org/10918 (quota: fix for spurious failure) posted (#5) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 10 Anand Avati 2015-05-27 16:09:48 UTC
COMMIT: http://review.gluster.org/10918 committed in master by Vijay Bellur (vbellur) 
------
commit f7bc35358c27d6260d5d1c4e22f1708d7ab60a98
Author: vmallika <vmallika>
Date:   Wed May 27 16:25:27 2015 +0530

    quota: fix for spurious failure
    
    During ancestry build, loc path was set to invalid
    path. path was set to one of its child instead
    of itself. Because of this quota accounting was
    going wrong
    
    This patch fix the issue
    
    Below mentioned tests removed from bad test list
    as part of patch# 10930
            ./tests/basic/ec/quota.t
            ./tests/basic/quota-nfs.t
            ./tests/bugs/quota/bug-1035576.t
    
    Change-Id: Iaa65b2d968c04c9abcd476d0e9f588cb7fd39294
    BUG: 1223798
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/10918
    Tested-by: NetBSD Build System
    Reviewed-by: Vijay Bellur <vbellur>

Comment 11 Niels de Vos 2015-06-02 08:20:20 UTC
The required changes to fix this bug have not made it into glusterfs-3.7.1. This bug is now getting tracked for glusterfs-3.7.2.

Comment 12 Niels de Vos 2015-06-20 10:08:28 UTC
Unfortunately glusterfs-3.7.2 did not contain a code change that was associated with this bug report. This bug is now proposed to be a blocker for glusterfs-3.7.3.

Comment 13 Vijaikumar Mallikarjuna 2015-06-22 06:59:25 UTC
Fixed in below patches and are merged
Upstream patch:
    http://review.gluster.org/#/c/10878/
    http://review.gluster.org/#/c/10918/

Release-3.7 patch:
    http://review.gluster.org/#/c/10910/
    http://review.gluster.org/#/c/10958/

Comment 14 Niels de Vos 2016-06-16 13:03:49 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.