Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1230259

Summary:	Honour afr self-heal volume set options from clients
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	replicate	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.6.3	CC:	bugs, gluster-bugs, rabhat
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.4beta2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1226507	Environment:
Last Closed:	2015-11-17 12:13:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1226507
Bug Blocks:	1216965, 1227674, 1228518

Description Ravishankar N 2015-06-10 13:56:40 UTC

+++ This bug was initially created as a clone of Bug #1226507 +++



--- Additional comment from Anand Avati on 2015-05-30 01:07:39 EDT ---

REVIEW: http://review.gluster.org/11012 (afr: honour selfheal enable/disable volume set options) posted (#1) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Krutika Dhananjay on 2015-05-30 01:22:52 EDT ---



--- Additional comment from Anand Avati on 2015-06-01 07:03:27 EDT ---

REVIEW: http://review.gluster.org/11012 (afr: honour selfheal enable/disable volume set options) posted (#2) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Anand Avati on 2015-06-03 06:50:50 EDT ---

COMMIT: http://review.gluster.org/11012 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit da111ae21429d33179cd11409bc171fae9d55194
Author: Ravishankar N <ravishankar>
Date:   Sat May 30 10:23:33 2015 +0530

    afr: honour selfheal enable/disable volume set options
    
    afr-v1 had the following volume set options that are used to enable/ disable
    self-heals from happening in AFR xlator when loaded in the client graph:
    cluster.metadata-self-heal
    cluster.data-self-heal
    cluster.entry-self-heal
    
    In afr-v2, these 3 heals can happen from the client if there is an inode
    refresh. This patch allows such heals to proceed only if the corresponding
    volume set options are set to true.
    
    Change-Id: I8d97d6020611152e73a269f3fdb607652c66cc86
    BUG: 1226507
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/11012
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 1 Anand Avati 2015-06-11 06:43:09 UTC

REVIEW: http://review.gluster.org/11170 (afr: honour selfheal enable/disable volume set options) posted (#1) for review on release-3.6 by Ravishankar N (ravishankar)

Comment 2 Anand Avati 2015-06-15 13:18:49 UTC

COMMIT: http://review.gluster.org/11170 committed in release-3.6 by Raghavendra Bhat (raghavendra) 
------
commit fecebde3fbae17ace970a4d9c440f6455161dc62
Author: Ravishankar N <ravishankar>
Date:   Sat May 30 10:23:33 2015 +0530

    afr: honour selfheal enable/disable volume set options
    
    Backport of  http://review.gluster.org/11012
    Note: http://review.gluster.org/9459 is not backported to 3.6 but the change it
    makes to afr_get_heal_info() (i.e. handling ret values) is needed for heal info
    to work correctly and tests/basic/afr/client-side-heal.t to pass.
    
    --------------------------
    afr-v1 had the following volume set options that are used to enable/ disable
    self-heals from happening in AFR xlator when loaded in the client graph:
    cluster.metadata-self-heal
    cluster.data-self-heal
    cluster.entry-self-heal
    
    In afr-v2, these 3 heals can happen from the client if there is an inode
    refresh. This patch allows such heals to proceed only if the corresponding
    volume set options are set to true.
    --------------------------
    
    Change-Id: Iebf863758d902fd2f95be320c6791d4e15f634e7
    BUG: 1230259
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/11170
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anuradha Talur <atalur>
    Reviewed-by: Raghavendra Bhat <raghavendra>