Bug 1299010 - UI: Automate/Simulation screen throws an error
Summary: UI: Automate/Simulation screen throws an error
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.5.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: GA
: 5.6.0
Assignee: Harpreet Kataria
QA Contact: Jeff Teehan
URL:
Whiteboard:
Depends On:
Blocks: 1299027
TreeView+ depends on / blocked
 
Reported: 2016-01-15 17:00 UTC by Harpreet Kataria
Modified: 2016-06-29 15:30 UTC (History)
8 users (show)

Fixed In Version: 5.6.0.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1299027 (view as bug list)
Environment:
Last Closed: 2016-06-29 15:30:43 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1348 0 normal SHIPPED_LIVE CFME 5.6.0 bug fixes and enhancement update 2016-06-29 18:50:04 UTC

Description Harpreet Kataria 2016-01-15 17:00:52 UTC
Description of problem:Going to Automate/Simulation screen throws an error


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Go To Automate/Simulation screen
2.
3.

Actual results:

[----] F, [2016-01-15T11:58:37.651056 #13869:5cf990] FATAL -- : Error caught: [NoMethodError] undefined method `encoding' for nil:NilClass
/home/hkataria/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.5/lib/active_support/core_ext/uri.rb:13:in `unescape'
/home/hkataria/.rvm/rubies/ruby-2.2.2/lib/ruby/2.2.0/uri/common.rb:125:in `unescape'
/home/hkataria/dev/manageiq/app/views/layouts/_content.html.haml:24:in `_app_views_layouts__content_html_haml___986300210564037647_170077440'


Expected results: Simulation screen should load


Additional info:

Comment 2 Harpreet Kataria 2016-01-15 17:49:34 UTC
https://github.com/ManageIQ/manageiq/pull/6202

Comment 3 CFME Bot 2016-01-15 21:41:00 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/3afcf8ba4b74f3e6d4403582ded6130d4933589a

commit 3afcf8ba4b74f3e6d4403582ded6130d4933589a
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Jan 15 12:45:53 2016 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri Jan 15 15:29:02 2016 -0500

    Added @right_cell_text for Automate Simulation screen
    
    URI.unescape was blowing up since @right_cell_text was nil. This issue was introduced with changes in https://github.com/ManageIQ/manageiq/pull/6140 for https://bugzilla.redhat.com/show_bug.cgi?id=1282606. Added code to set @right_cell_text and also added check to only URI.unescape if @right_cell_text is not nil
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1299010

 app/controllers/application_controller/automate.rb | 1 +
 app/views/layouts/_content.html.haml               | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Comment 4 CFME Bot 2016-01-15 22:57:25 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=6809c432a3e7b48bc8aa86933766c95b5afa9c2a

commit 6809c432a3e7b48bc8aa86933766c95b5afa9c2a
Merge: ca87970 e853721
Author:     Dan Clarizio <dclarizi>
AuthorDate: Fri Jan 15 17:53:48 2016 -0500
Commit:     Dan Clarizio <dclarizi>
CommitDate: Fri Jan 15 17:53:48 2016 -0500

    Merge branch '55z_pr_6202' into '5.5.z'
    
    Added @right_cell_text for Automate Simulation screen
    
    URI.unescape was blowing up since @right_cell_text was nil. This issue was introduced with changes in https://github.com/ManageIQ/manageiq/pull/6140 for https://bugzilla.redhat.com/show_bug.cgi?id=1282606. Added code to set @right_cell_text and also added check to only URI.unescape if @right_cell_text is not nil
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1299010
    https://bugzilla.redhat.com/show_bug.cgi?id=1299027
    (cherry picked from commit 3afcf8b)
    
    @dclarizi please review/merge, clean cherry-pick for https://github.com/ManageIQ/manageiq/pull/6202
    
    See merge request !724

 app/controllers/application_controller/automate.rb | 1 +
 app/views/layouts/_content.html.haml               | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Comment 5 CFME Bot 2016-01-15 22:57:33 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=e8537212c5de87842d3dcc5a8185d6095cf392a3

commit e8537212c5de87842d3dcc5a8185d6095cf392a3
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Jan 15 12:45:53 2016 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri Jan 15 16:30:53 2016 -0500

    Added @right_cell_text for Automate Simulation screen
    
    URI.unescape was blowing up since @right_cell_text was nil. This issue was introduced with changes in https://github.com/ManageIQ/manageiq/pull/6140 for https://bugzilla.redhat.com/show_bug.cgi?id=1282606. Added code to set @right_cell_text and also added check to only URI.unescape if @right_cell_text is not nil
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1299010
    https://bugzilla.redhat.com/show_bug.cgi?id=1299027
    (cherry picked from commit 3afcf8b)

 app/controllers/application_controller/automate.rb | 1 +
 app/views/layouts/_content.html.haml               | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Comment 7 CFME Bot 2016-01-20 03:42:51 UTC
Detected commit referencing this ticket while ticket status is MODIFIED.

Comment 8 Jeff Teehan 2016-04-19 17:40:47 UTC
It's working for 5.6.0.1.  Moving to Verified using https://10.16.7.174/miq_ae_tools/resolve to test verification.

Comment 10 errata-xmlrpc 2016-06-29 15:30:43 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348


Note You need to log in before you can comment on or make changes to this bug.