Description of problem: When user runs "gluster volume bitrot <vol_name> scrub status" values for Number of Scrubbed files, Number of Unsigned files, Last completed scrub time and Duration of last scrub are shown as zero. [root@linux1]# gluster vol bitrot vol1 scrub status Volume name : vol1 State of scrub: Active Scrub impact: lazy Scrub frequency: hourly Bitrot error log location: /var/log/glusterfs/bitd.log Scrubber error log location: /var/log/glusterfs/scrub.log ========================================================= Node name: localhost Number of Scrubbed files: 0 Number of Unsigned files: 0 Last completed scrub time: 0 Duration of last scrub: 0 Error count: 1 Corrupted object's: 522a6019-bde9-4963-b1d6-bbdaf27c788a ========================================================= Node name: 10.70.36.57 Number of Scrubbed files: 0 Number of Unsigned files: 0 Last completed scrub time: 0 Duration of last scrub: 0 Error count: 0 ========================================================= Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. create a volume and enable bitrot on that. 2. Run the command gluster volume bitrot <vol_name> scrub status Actual results: values for Number of Scrubbed files, Number of Unsigned files, Last completed scrub time and Duration of last scrub are shown as zero. Expected results: actual Values should be shown for Number of Scrubbed files, Number of Unsigned files, Last completed scrub time and Duration of last scrub and not zeros.
REVIEW: http://review.gluster.org/14140 (features/bitrot: Introduce scrubber monitor thread) posted (#1) for review on release-3.7 by Kotresh HR (khiremat)
REVIEW: http://review.gluster.org/14141 (glusterd/bitrot: Fix bit-rot scrub status) posted (#1) for review on release-3.7 by Kotresh HR (khiremat)
REVIEW: http://review.gluster.org/14142 (cli/bitrot: Unmask scrub statistics) posted (#1) for review on release-3.7 by Kotresh HR (khiremat)
REVIEW: http://review.gluster.org/14142 (cli/bitrot: Unmask scrub statistics) posted (#2) for review on release-3.7 by Kotresh HR (khiremat)
REVIEW: http://review.gluster.org/14140 (features/bitrot: Introduce scrubber monitor thread) posted (#2) for review on release-3.7 by Kotresh HR (khiremat)
REVIEW: http://review.gluster.org/14141 (glusterd/bitrot: Fix bit-rot scrub status) posted (#2) for review on release-3.7 by Kotresh HR (khiremat)
COMMIT: http://review.gluster.org/14140 committed in release-3.7 by Venky Shankar (vshankar) ------ commit 83f49e5619900a17918f1029c7a428f0cbe51813 Author: Kotresh HR <khiremat> Date: Fri Apr 29 17:45:31 2016 +0530 features/bitrot: Introduce scrubber monitor thread The patch does following changes. 1. Introduce scrubber monitor thread. 2. Move scrub status related APIs to separate file and make part of libbitrot library. Problem: Earlier, each child of the scrubber was maintaining the state machine and hence there was no way to track the start and end time of scrubbing as each brick has it's own start and end time. Also each brick was maintaining it's own timer wheel instance. It was also not possible to get scrubbed files count per session as we could not get last child which finishes scrubbing to reset it to zero. Solution: Introduce scrubber monitor thread. It does following. 1. Maintains the scrubber state machine. Earlier each child had it's own state machine. Now, only monitor maintains on behalf of all it's children. 2. Maintains the timer wheel instance. Earlier each child had it's own timer wheel instance. Now, only monitor maintains on behalf of all it's children. As a result, we can track the scrub statistics easily and correctly. Backport of: >Change-Id: Ic6e34ffa57984bd7a5ee81f4e263342bc1d9b302 >BUG: 1329211 >Signed-off-by: Kotresh HR <khiremat> >Reviewed-on: http://review.gluster.org/14044 >Smoke: Gluster Build System <jenkins.com> >NetBSD-regression: NetBSD Build System <jenkins.org> >CentOS-regression: Gluster Build System <jenkins.com> >Reviewed-by: Venky Shankar <vshankar> Backport of: >http://review.gluster.org/#/c/14146 >BUG: 1332134 NOTE: The patch #14146 is a compilation warning not detected in master branch and detected only in 3.7 branch. Since the compilation warning is introduced by patch #14044, the above two backports are made into this single patch. Change-Id: I1da7a3ec673a36ae0f59dc33ac5992c74fd7a19b BUG: 1332072 Signed-off-by: Kotresh HR <khiremat> Reviewed-on: http://review.gluster.org/14140 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Venky Shankar <vshankar>
COMMIT: http://review.gluster.org/14141 committed in release-3.7 by Venky Shankar (vshankar) ------ commit 32101f782552cef7666be7294533c71da821b22c Author: Kotresh HR <khiremat> Date: Wed Apr 20 23:49:39 2016 +0530 glusterd/bitrot: Fix bit-rot scrub status Few of the dictionary values were not allocated and set. This patch allocates them and set. Backport of: >Change-Id: Ic61c1209b238e45219793fd8bec92235adfbd013 >BUG: 1329211 >Signed-off-by: Kotresh HR <khiremat> >Reviewed-on: http://review.gluster.org/14120 >Smoke: Gluster Build System <jenkins.com> >NetBSD-regression: NetBSD Build System <jenkins.org> >CentOS-regression: Gluster Build System <jenkins.com> >Reviewed-by: Venky Shankar <vshankar> >Reviewed-by: Atin Mukherjee <amukherj> >Signed-off-by: Kotresh HR <khiremat> Change-Id: Icf52a98a9699c6bd0b2dff159626f87030c76d72 BUG: 1332072 Signed-off-by: Kotresh HR <khiremat> Reviewed-on: http://review.gluster.org/14141 Smoke: Gluster Build System <jenkins.com> CentOS-regression: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Venky Shankar <vshankar>
COMMIT: http://review.gluster.org/14142 committed in release-3.7 by Venky Shankar (vshankar) ------ commit d67d30e63f11d926ca8e46ea208758703566a76f Author: Kotresh HR <khiremat> Date: Wed Apr 20 17:53:50 2016 +0530 cli/bitrot: Unmask scrub statistics Revert the commit 2a37dbd845348a774f45c4d77cffebc32c749251 The scrub statistics were masked because of inaccurate stats. Now with http://review.gluster.org/#/c/14044/ it's fixed, hence unmasking it. >Change-Id: Iffff5f48eb8121b617af82ecfb70bec5b2772c23 >BUG: 1329211 >Signed-off-by: Kotresh HR <khiremat> >Reviewed-on: http://review.gluster.org/14121 >Smoke: Gluster Build System <jenkins.com> >NetBSD-regression: NetBSD Build System <jenkins.org> >CentOS-regression: Gluster Build System <jenkins.com> >Reviewed-by: Venky Shankar <vshankar> >Reviewed-by: Atin Mukherjee <amukherj> >Signed-off-by: Kotresh HR <khiremat> Change-Id: I958bcae4eebca6bdf7b80866e2c40d3428ef78a4 BUG: 1332072 Signed-off-by: Kotresh HR <khiremat> Reviewed-on: http://review.gluster.org/14142 Smoke: Gluster Build System <jenkins.com> CentOS-regression: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Venky Shankar <vshankar>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.12, please open a new bug report. glusterfs-3.7.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-devel/2016-June/049918.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user