Description of problem: When user runs "gluster volume bitrot <vol_name> scrub status" values for Number of Scrubbed files, Number of Unsigned files, Last completed scrub time and Duration of last scrub are shown as zero. [root@linux1]# gluster vol bitrot vol1 scrub status Volume name : vol1 State of scrub: Active Scrub impact: lazy Scrub frequency: hourly Bitrot error log location: /var/log/glusterfs/bitd.log Scrubber error log location: /var/log/glusterfs/scrub.log ========================================================= Node name: localhost Number of Scrubbed files: 0 Number of Unsigned files: 0 Last completed scrub time: 0 Duration of last scrub: 0 Error count: 1 Corrupted object's: 522a6019-bde9-4963-b1d6-bbdaf27c788a ========================================================= Node name: 10.70.36.57 Number of Scrubbed files: 0 Number of Unsigned files: 0 Last completed scrub time: 0 Duration of last scrub: 0 Error count: 0 ========================================================= Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. create a volume and enable bitrot on that. 2. Run the command gluster volume bitrot <vol_name> scrub status Actual results: values for Number of Scrubbed files, Number of Unsigned files, Last completed scrub time and Duration of last scrub are shown as zero. Expected results: actual Values should be shown for Number of Scrubbed files, Number of Unsigned files, Last completed scrub time and Duration of last scrub and not zeros.
REVIEW: http://review.gluster.org/14201 (features/bitrot: Introduce scrubber monitor thread) posted (#1) for review on release-3.8 by Kotresh HR (khiremat)
REVIEW: http://review.gluster.org/14202 (glusterd/bitrot: Fix bit-rot scrub status) posted (#1) for review on release-3.8 by Kotresh HR (khiremat)
REVIEW: http://review.gluster.org/14203 (cli/bitrot: Unmask scrub statistics) posted (#1) for review on release-3.8 by Kotresh HR (khiremat)
COMMIT: http://review.gluster.org/14201 committed in release-3.8 by Venky Shankar (vshankar) ------ commit e63049cba0f2b94b0b082cc8bfd5921b8443ef45 Author: Kotresh HR <khiremat> Date: Fri Apr 29 17:45:31 2016 +0530 features/bitrot: Introduce scrubber monitor thread The patch does following changes. 1. Introduce scrubber monitor thread. 2. Move scrub status related APIs to separate file and make part of libbitrot library. Problem: Earlier, each child of the scrubber was maintaining the state machine and hence there was no way to track the start and end time of scrubbing as each brick has it's own start and end time. Also each brick was maintaining it's own timer wheel instance. It was also not possible to get scrubbed files count per session as we could not get last child which finishes scrubbing to reset it to zero. Solution: Introduce scrubber monitor thread. It does following. 1. Maintains the scrubber state machine. Earlier each child had it's own state machine. Now, only monitor maintains on behalf of all it's children. 2. Maintains the timer wheel instance. Earlier each child had it's own timer wheel instance. Now, only monitor maintains on behalf of all it's children. As a result, we can track the scrub statistics easily and correctly. Upstream master: http://review.gluster.org/14044 http://review.gluster.org/#/c/14146 Upstream 3.7: http://review.gluster.org/14140 NOTE: The patch #14146 is a compilation warning not detected in master branch and detected only in 3.7 branch. Since the compilation warning is introduced by patch #14044, the above two backports are made into this single patch in 3.7 and the same is backported to 3.8. BUG: 1332839 Change-Id: I1cec0b229c851fec793a1288c23e43bcec755cba Signed-off-by: Kotresh HR <khiremat> Reviewed-on: http://review.gluster.org/14201 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Venky Shankar <vshankar>
COMMIT: http://review.gluster.org/14202 committed in release-3.8 by Venky Shankar (vshankar) ------ commit 911e85a54d0355df3d28be63cc4793d904da17fa Author: Kotresh HR <khiremat> Date: Wed Apr 20 23:49:39 2016 +0530 glusterd/bitrot: Fix bit-rot scrub status Few of the dictionary values were not allocated and set. This patch allocates them and set. Backport of: >Change-Id: Ic61c1209b238e45219793fd8bec92235adfbd013 >BUG: 1329211 >Signed-off-by: Kotresh HR <khiremat> >Reviewed-on: http://review.gluster.org/14120 >Smoke: Gluster Build System <jenkins.com> >NetBSD-regression: NetBSD Build System <jenkins.org> >CentOS-regression: Gluster Build System <jenkins.com> >Reviewed-by: Venky Shankar <vshankar> >Reviewed-by: Atin Mukherjee <amukherj> >Signed-off-by: Kotresh HR <khiremat> BUG: 1332839 Change-Id: If54f0180aaef8ea9ea1544da925ae065becfe53e Signed-off-by: Kotresh HR <khiremat> Reviewed-on: http://review.gluster.org/14202 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Venky Shankar <vshankar>
COMMIT: http://review.gluster.org/14203 committed in release-3.8 by Venky Shankar (vshankar) ------ commit 9c7c83d7ac285a92607038321a51137ff3879c93 Author: Kotresh HR <khiremat> Date: Wed Apr 20 17:53:50 2016 +0530 cli/bitrot: Unmask scrub statistics Revert the commit 2a37dbd845348a774f45c4d77cffebc32c749251 The scrub statistics were masked because of inaccurate stats. Now with http://review.gluster.org/#/c/14044/ it's fixed, hence unmasking it. >Change-Id: Iffff5f48eb8121b617af82ecfb70bec5b2772c23 >BUG: 1329211 >Signed-off-by: Kotresh HR <khiremat> >Reviewed-on: http://review.gluster.org/14121 >Smoke: Gluster Build System <jenkins.com> >NetBSD-regression: NetBSD Build System <jenkins.org> >CentOS-regression: Gluster Build System <jenkins.com> >Reviewed-by: Venky Shankar <vshankar> >Reviewed-by: Atin Mukherjee <amukherj> >Signed-off-by: Kotresh HR <khiremat> BUG: 1332839 Change-Id: Icbdfd28eb9de5a149432c0aac1be4966c6b0fb06 Signed-off-by: Kotresh HR <khiremat> Reviewed-on: http://review.gluster.org/14203 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Atin Mukherjee <amukherj>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user