Bug 1337596 - Mounting a volume over NFS with a subdir followed by a / returns "Invalid argument"
Summary: Mounting a volume over NFS with a subdir followed by a / returns "Invalid arg...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: nfs
Version: 3.8.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Niels de Vos
QA Contact:
URL:
Whiteboard:
Depends On: 1337597
Blocks: glusterfs-3.8.0
TreeView+ depends on / blocked
 
Reported: 2016-05-19 14:56 UTC by Niels de Vos
Modified: 2016-06-16 14:07 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1337597 (view as bug list)
Environment:
Last Closed: 2016-06-16 14:07:31 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2016-05-19 14:56:24 UTC
Description of problem:


Mounting a volume over NFS with a subdir followed by a / does not work:

  # mount -t nfs -o vers=3 storage.example.com:/media/installation/ /mnt
  mount.nfs: an incorrect mount option was specified

In the nfs.log:

  [client-rpc-fops.c:2930:client3_3_lookup_cbk] 0-media-client-0: remote operation failed. Path: /installation/ (00000000-0000-0000-0000-000000000000) [Invalid argument]
  [client-rpc-fops.c:2930:client3_3_lookup_cbk] 0-media-client-1: remote operation failed. Path: /installation/ (00000000-0000-0000-0000-000000000000) [Invalid argument]
  [mount3.c:1134:mnt3_resolve_subdir_cbk] 0-nfs: path=/installation/ (Invalid argument) [Invalid argument]



Version-Release number of selected component (if applicable):
glusterfs-3.8rc0

Comment 1 Vijay Bellur 2016-05-19 15:04:14 UTC
REVIEW: http://review.gluster.org/14424 (nfs: testcase for subdir mounting with a trailing /) posted (#1) for review on release-3.8 by Niels de Vos (ndevos)

Comment 2 Vijay Bellur 2016-05-20 07:28:20 UTC
REVIEW: http://review.gluster.org/14424 (nfs: strip trailing / when clients do subdir mounts) posted (#2) for review on release-3.8 by Niels de Vos (ndevos)

Comment 3 Vijay Bellur 2016-05-24 08:35:12 UTC
COMMIT: http://review.gluster.org/14424 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit 125c2f6d06dfeace7469adf3e5d7be98dd34d3c3
Author: Niels de Vos <ndevos>
Date:   Thu May 19 12:53:09 2016 +0200

    nfs: strip trailing / when clients do subdir mounts
    
    Mounting a volume over NFS with a subdir followed by a / does not work:
    
      # mount -t nfs -o vers=3 storage.example.com:/media/installation/ /mnt
      mount.nfs: an incorrect mount option was specified
    
    In the nfs.log:
    
      [client-rpc-fops.c:2930:client3_3_lookup_cbk] 0-media-client-0: remote operation failed. Path: /installation/ (00000000-0000-0000-0000-000000000000) [Invalid argument]
      [client-rpc-fops.c:2930:client3_3_lookup_cbk] 0-media-client-1: remote operation failed. Path: /installation/ (00000000-0000-0000-0000-000000000000) [Invalid argument]
      [mount3.c:1134:mnt3_resolve_subdir_cbk] 0-nfs: path=/installation/ (Invalid argument) [Invalid argument]
    
    It is not possible to resolve paths with a trailing /. Stripping
    trailing /'s from the subdir to mount is sufficient to make it work
    again.
    
    Backport:
    > Change-Id: I4075d4cd351438de58e1ff81f0fb65a1ff076da4
    > BUG: 1337597
    > Reviewed-on: http://review.gluster.org/14421
    > Signed-off-by: Niels de Vos <ndevos>
    
    Change-Id: I4075d4cd351438de58e1ff81f0fb65a1ff076da4
    BUG: 1337596
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/14424
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: jiffin tony Thottan <jthottan>

Comment 4 Niels de Vos 2016-06-16 14:07:31 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.