Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1342919 - (configure_discard_per_domain_and_disk) [RFE] Make discard configurable by a storage domain rather than a host
[RFE] Make discard configurable by a storage domain rather than a host
Status: CLOSED CURRENTRELEASE
Product: ovirt-engine
Classification: oVirt
Component: Backend.Core (Show other bugs)
3.6.2
Unspecified Unspecified
high Severity high (vote)
: ovirt-4.1.0-beta
: 4.1.0.2
Assigned To: Idan Shaby
Kevin Alon Goldblatt
: FutureFeature
Depends On: send_discard_when_deleting_disks
Blocks: 1420186
  Show dependency treegraph
 
Reported: 2016-06-06 02:36 EDT by Idan Shaby
Modified: 2017-06-18 04:13 EDT (History)
14 users (show)

See Also:
Fixed In Version:
Doc Type: Enhancement
Doc Text:
With this update, it is now possible to configure discard after delete per block storage domain. Previously, a user could get similar functionality by configuring the discard_enable parameter in the VDSM configuration file. This caused each logical volume (disk or snapshot) that was about to be removed by this specific host to be discarded first. Now, discard after delete can be enabled for a block storage domain, rather than a host. This means that if discard after delete is enabled it no longer matters which host removes the logical volume as each logical volume under this domain will be discarded before it is removed.
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-02-15 09:59:42 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: Storage
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rule-engine: ovirt‑4.1+
bmcclain: priority_rfe_tracking+
ratamir: testing_plan_complete+
ylavi: planning_ack+
tnisan: devel_ack+
ratamir: testing_ack+


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
oVirt gerrit 60628 master MERGED storage: add getDeviceList discard related fields 2016-07-20 17:14 EDT
oVirt gerrit 67487 master MERGED Introduce StorageDomain::discardAfterDelete 2016-11-30 02:36 EST
oVirt gerrit 67845 master MERGED backend: rename PostZero to PostDeleteAction 2016-12-12 06:53 EST
oVirt gerrit 67846 master MERGED backend: generalize method names in BlockStorageDiscardFunctionalityHelper 2016-12-12 06:54 EST
oVirt gerrit 67847 master MERGED core: add Discard After Delete to storage domain 2016-12-14 17:22 EST
oVirt gerrit 67925 master MERGED storage: add discard argument to all related flows 2016-12-13 08:36 EST
oVirt gerrit 68083 master MERGED backend: use injections in PostDeleteActionHandler 2016-12-12 06:53 EST
oVirt gerrit 68084 master MERGED core: send discard to vdsm according to DAD value 2016-12-14 17:22 EST
oVirt gerrit 68105 master MERGED webadmin: add Discard After Delete to storage view 2016-12-14 17:22 EST
oVirt gerrit 68459 master POST storage: add missing discard parameter 2016-12-14 08:07 EST

  None (edit)
Description Idan Shaby 2016-06-06 02:36:25 EDT
Description of problem:
Today, sending discard when removing a disk or a snapshot can be configured on the vdsm configuration file for a host. That means that a host with this property on will send discard calls for each disk/snapshot removal on any block storage domain.

Since the user might want to send discard calls only for some storage domains (those who are built on thin provisioned storage that supports discard), we should change this configuration from host oriented to block storage domain oriented.
Comment 1 Red Hat Bugzilla Rules Engine 2016-06-06 02:37:33 EDT
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Note You need to log in before you can comment on or make changes to this bug.