Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1354607

Summary: [FC23] firewalld version detection is broken
Product: [oVirt] otopi Reporter: Yedidyah Bar David <didi>
Component: Plugins.networkAssignee: Yedidyah Bar David <didi>
Status: CLOSED CURRENTRELEASE QA Contact: Pavol Brilla <pbrilla>
Severity: high Docs Contact:
Priority: unspecified    
Version: masterCC: bugs, lsvaty, oourfali, sbonazzo
Target Milestone: ovirt-4.0.1Keywords: Rebase, Regression, ZStream
Target Release: 1.5.1Flags: rule-engine: ovirt-4.0.z+
rule-engine: blocker+
rule-engine: planning_ack+
sbonazzo: devel_ack+
pstehlik: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Rebase: Bug Fixes and Enhancements
Doc Text:
Rebase otopi to support firewalld version >= 0.4.3.2 Highlights, important fixes, or notable enhancements: Fixes firewalld detection with firewalld >= 0.4.3.2 shipped with Fedora >= 23
Story Points: ---
Clone Of:
: 1491663 1491666 (view as bug list) Environment:
Last Closed: 2016-07-26 11:01:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1306739, 1491663, 1491666, 1503440    

Description Yedidyah Bar David 2016-07-11 17:02:56 UTC
Description of problem:

A recent-enough version of firewalld causes otopi to not detect firewalld version, with this in the log:

2016-07-11 19:53:32 DEBUG otopi.plugins.otopi.network.firewalld firewalld._get_firewalld_cmd_version:118 Exception during firewalld dection
Traceback (most recent call last):
  File "/usr/share/otopi/plugins/otopi/network/firewalld.py", line 105, in _get_firewalld_cmd_version
    self.logger.debug('firewalld version: %s', client.VERSION)
AttributeError: 'module' object has no attribute 'VERSION'

Version-Release number of selected component (if applicable):

firewalld-0.4.3.2-1

Used to work with firewalld-0.3.9-14

How reproducible:
Always

Steps to Reproduce:
1. Run 'otopi'
2.
3.

Actual results:
See above

Expected results:
Correctly identifies version

Additional info:

Comment 1 Red Hat Bugzilla Rules Engine 2016-07-11 17:42:46 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 3 Lukas Svaty 2016-07-26 11:01:27 UTC
This bug was fixed and is slated to be in the upcoming version. As we
are focusing our testing at this phase on severe bugs, this bug was
closed without going through its verification step. If you think this
bug should be verified by QE, please set its severity to high and move
it back to ON_QA