Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1491663

Summary:	[downstream clone - 4.0.1] [FC23] firewalld version detection is broken
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	rhev-integ
Component:	otopi	Assignee:	Yedidyah Bar David <didi>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Lucie Leistnerova <lleistne>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	bazulay, bugs, dougsland, lleistne, lsurette, lsvaty, rbalakri, Rhev-m-bugs, sbonazzo, srevivo, ykaul
Target Milestone:	ovirt-4.1.6	Keywords:	TestOnly, ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Rebase: Bug Fixes and Enhancements
Doc Text:	Rebase otopi to support firewalld version >= 0.4.3.2 Highlights, important fixes, or notable enhancements: Fixes firewalld detection with firewalld >= 0.4.3.2 shipped with Fedora >= 23	Story Points:	---
Clone Of:	1354607	Environment:
Last Closed:	2017-10-02 12:30:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1354607
Bug Blocks:

Description rhev-integ 2017-09-14 11:36:06 UTC

+++ This bug is an upstream to downstream clone. The original bug is: +++
+++   bug 1354607 +++
======================================================================

Description of problem:

A recent-enough version of firewalld causes otopi to not detect firewalld version, with this in the log:

2016-07-11 19:53:32 DEBUG otopi.plugins.otopi.network.firewalld firewalld._get_firewalld_cmd_version:118 Exception during firewalld dection
Traceback (most recent call last):
  File "/usr/share/otopi/plugins/otopi/network/firewalld.py", line 105, in _get_firewalld_cmd_version
    self.logger.debug('firewalld version: %s', client.VERSION)
AttributeError: 'module' object has no attribute 'VERSION'

Version-Release number of selected component (if applicable):

firewalld-0.4.3.2-1

Used to work with firewalld-0.3.9-14

How reproducible:
Always

Steps to Reproduce:
1. Run 'otopi'
2.
3.

Actual results:
See above

Expected results:
Correctly identifies version

Additional info:

(Originally by didi)

Comment 1 rhev-integ 2017-09-14 11:36:14 UTC

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

(Originally by rule-engine)

Comment 4 rhev-integ 2017-09-14 11:36:26 UTC

This bug was fixed and is slated to be in the upcoming version. As we
are focusing our testing at this phase on severe bugs, this bug was
closed without going through its verification step. If you think this
bug should be verified by QE, please set its severity to high and move
it back to ON_QA

(Originally by Lukas Svaty)

Comment 5 Yedidyah Bar David 2017-09-14 11:48:07 UTC

Handling 3.6 in bug 1491666. 4.0 should be ok.

Comment 6 Lucie Leistnerova 2017-09-18 08:16:08 UTC

firewalld version detected properly on rhel7

DEBUG otopi.plugins.otopi.network.firewalld firewalld._get_firewalld_cmd_version:105 firewalld version: 0.4.4.4

verified in otopi-1.6.2-1.el7ev.noarch, ovirt-engine-4.1.6.2-0.1.el7.noarch