+++ This bug was initially created as a clone of Bug #1374412 +++ Description of problem: Detach tier commit operation should not be allowed when detach tier start operation has gone into failed state. There might be files which are not moved from hot to cold tier when a detach tier operation fails. Allowing to commit the operation removes off the hot tier bricks, thereby making those data in hot tier inaccessible. Version-Release number of selected component (if applicable): rpm -qa | grep 'gluster' glusterfs-cli-3.8.3-0.1.git2ea32d9.el7.centos.x86_64 glusterfs-server-3.8.3-0.1.git2ea32d9.el7.centos.x86_64 python-gluster-3.8.3-0.1.git2ea32d9.el7.centos.noarch glusterfs-client-xlators-3.8.3-0.1.git2ea32d9.el7.centos.x86_64 glusterfs-3.8.3-0.1.git2ea32d9.el7.centos.x86_64 glusterfs-fuse-3.8.3-0.1.git2ea32d9.el7.centos.x86_64 nfs-ganesha-gluster-next.20160813.2f47e8a-1.el7.centos.x86_64 glusterfs-libs-3.8.3-0.1.git2ea32d9.el7.centos.x86_64 glusterfs-api-3.8.3-0.1.git2ea32d9.el7.centos.x86_64 glusterfs-ganesha-3.8.3-0.1.git2ea32d9.el7.centos.x86_64 How reproducible: Always Steps to Reproduce: 1. create a tier vol and start detach tier operation 2. kill a brick on hot tier and restore it after a while to fail the detach tier operation 3. Try detach tier commit Actual results: detach tier commit is allowed Expected results: detach tier commit should not be allowed Additional info:
REVIEW: http://review.gluster.org/15438 (Tier: failing detach commit on detach failure and in-progress) posted (#1) for review on master by hari gowtham (hari.gowtham005)
REVIEW: http://review.gluster.org/15438 (Tier: failing detach commit on detach failure and in-progress) posted (#2) for review on master by hari gowtham (hari.gowtham005)
COMMIT: http://review.gluster.org/15438 committed in master by Dan Lambright (dlambrig) ------ commit 1afa0bd91fd23b5131ccc1cceb814a061ac99096 Author: hari gowtham <hgowtham> Date: Fri Sep 9 12:26:52 2016 +0530 Tier: failing detach commit on detach failure and in-progress PROBLEM: if detach status has failed or if it remains in progress we allow detach commit to happen. only detach force should be allowed. FIX: check the detach status for failure or inprogress and disallow with the apt error message. Change-Id: Ib97d540fec67717bb55c18d133187c665cf69ef1 BUG: 1374584 Signed-off-by: hari gowtham <hgowtham> Reviewed-on: http://review.gluster.org/15438 Smoke: Gluster Build System <jenkins.org> Tested-by: hari gowtham <hari.gowtham005> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Dan Lambright <dlambrig> Tested-by: Dan Lambright <dlambrig>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report. glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html [2] https://www.gluster.org/pipermail/gluster-users/