Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
First Last Prev Next    This bug is not in your last search results.
Bug 1379924 - gfapi: Fix fd ref leaks
gfapi: Fix fd ref leaks
Status: CLOSED ERRATA
Product: Red Hat Gluster Storage
Classification: Red Hat
Component: libgfapi (Show other bugs)
3.2
All All
unspecified Severity high
: ---
: RHGS 3.2.0
Assigned To: Soumya Koduri
surabhi
: Triaged
Depends On: 1379285
Blocks: 1351528 1379707 1379708 1379710
  Show dependency tree / graph
 
Reported: 2016-09-28 02:53 EDT by Soumya Koduri
Modified: 2017-03-23 01:49 EDT (History)
9 users (show)

See Also:
Fixed In Version: glusterfs-3.8.4-3
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1379285
Environment:
Last Closed: 2017-03-23 01:49:35 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2017:0486 normal SHIPPED_LIVE Moderate: Red Hat Gluster Storage 3.2.0 security, bug fix, and enhancement update 2017-03-23 05:18:45 EDT

  None (edit)
Description Soumya Koduri 2016-09-28 02:53:23 EDT 
+++ This bug was initially created as a clone of Bug #1379285 +++

Description of problem:

From the code inspection, have observed that there are fd ref leaks for few fd-based gfapi fops. 'glfs_resolve_fd' returns a fd (either existing or migrated) with an extra ref taken. This needs to be unref'ed at the end of the operation.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-09-26 05:35:39 EDT ---

REVIEW: http://review.gluster.org/15573 (gfapi: Fix few fd ref leaks) posted (#1) for review on master by soumya k (skoduri@redhat.com)

--- Additional comment from Worker Ant on 2016-09-27 02:43:38 EDT ---

COMMIT: http://review.gluster.org/15573 committed in master by Niels de Vos (ndevos@redhat.com) 
------
commit d27cffab670858d7812bbb458a0833303d009b3b
Author: Soumya Koduri <skoduri@redhat.com>
Date:   Mon Sep 26 14:54:27 2016 +0530

    gfapi: Fix few fd ref leaks
    
    From the code inspection, have observed that there are fd ref
    leaks for few fd-based gfapi fops. 'glfs_resolve_fd' returns
    a fd (either existing or migrated) with an extra ref taken.
    This needs to be unref'ed at the end of the operation.
    
    Change-Id: Id63394e3e7deafb0c8b06444f2ae847248b126db
    BUG: 1379285
    Signed-off-by: Soumya Koduri <skoduri@redhat.com>
    Reviewed-on: http://review.gluster.org/15573
    NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
    Reviewed-by: Niels de Vos <ndevos@redhat.com>
    Smoke: Gluster Build System <jenkins@build.gluster.org>
Comment 5 Atin Mukherjee 2016-10-12 05:46:28 EDT 
Upstream mainline : http://review.gluster.org/15573
Upstream 3.8 : http://review.gluster.org/15585
downstream : https://code.engineering.redhat.com/gerrit/86107
Comment 7 surabhi 2016-11-23 07:07:07 EST 
Ran Basic sanity on ganesha and don't see any issues with fd leak.
Will have inputs from Samba and Qemu (users of libgfapi), if basic sanity works fine there , will move the BZ to verified.
Comment 8 Vivek Das 2016-11-24 05:45:13 EST 
Samba
-----
Ran basic sanity including mount, unmount, IOs, share connect disconnects and did not see any issues with fd leak.
Comment 9 SATHEESARAN 2016-11-24 05:47:35 EST 
Tested RHGS 3.2.0 interim build ( glusterfs-3.8.4-5.el7rhgs ) with RHEL 7.3 with following components :
qemu-img-rhev-2.6.0-27.el7.x86_64
qemu-kvm-rhev-2.6.0-27.el7.x86_64
libvirt-2.0.0-10.el7.x86_64

I could able to create VMs and ran I/O inside the VMs. All works good.

Note: I haven't tested for the memory footprint or fd leaks with gfapi
Comment 10 surabhi 2016-11-25 02:30:23 EST 
As there are no regressions seen on nfs-ganesha, samba and Qemu because of this patch, moving the BZ to verified.

nfs-ganesha-2.4.1-1.el7rhgs.x86_64
nfs-ganesha-gluster-2.4.1-1.el7rhgs.x86_64
glusterfs-ganesha-3.8.4-5.el7rhgs.x86_64

glusterfs-api-3.8.4-5.el7rhgs.x86_64
Comment 12 errata-xmlrpc 2017-03-23 01:49:35 EDT 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2017-0486.html
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.