Bug 1389293 - build: incorrect Requires: for portblock resource agent
Summary: build: incorrect Requires: for portblock resource agent
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kaleb KEITHLEY
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1278336 1389742
TreeView+ depends on / blocked
 
Reported: 2016-10-27 11:45 UTC by Kaleb KEITHLEY
Modified: 2017-03-06 17:31 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.10.0
Clone Of:
: 1389742 (view as bug list)
Environment:
Last Closed: 2017-01-24 11:51:57 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Kaleb KEITHLEY 2016-10-27 11:45:59 UTC
Description of problem:

email from buildsys warns that 
  	glusterfs-ganesha-3.9.0-0.1.rc2.fc26 requires /usr/lib/ocf/resource.d/portblock

glusterfs.spec(.in) has: 

  Requires:         %{_prefix}/lib/ocf/resource.d/portblock

should be:

  Requires:         %{_prefix}/lib/ocf/resource.d/heartbeat/portblock

and would probably be better as:

  Requires:       resource-agents (>= 3.9.6)

Fedora 23 has version 3.9.6 with portblock. RHEL7.2 has version 3.9.5 and no portblock.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2016-10-27 12:10:04 UTC
REVIEW: http://review.gluster.org/15743 (build: incorrect Requires for portblock resource agent) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 2 Worker Ant 2016-10-28 12:30:35 UTC
COMMIT: http://review.gluster.org/15743 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 1e421f75e040ebfce1bb6b36f9c213630807a45c
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Thu Oct 27 08:01:44 2016 -0400

    build: incorrect Requires for portblock resource agent
    
    was:
      Requires:    /usr/lib/ocf/resource.d/portblock
    s/b:
      Requires:    /usr/lib/ocf/resource.d/heartbeat/portblock
    or:
      Requires:    resource-agents >= 3.9.6
    
    Note: RHEL6.8 and RHEL7.2 have resource-agents-3.9.5 which does
    not contain the portblock resource agent.
    
    I'm not sure what the point is actually of:
    
      Requires:    /usr/lib/ocf/resource.d/heartbeat/portblock
    
    as it will fail to install on RHEL whether you have the
    resource-agents package installed or not. Hence wrapping it
    in %if ( fedora ).
    
    Change-Id: Ia7d6a475464c7469018678c98fc710a3b3bfc553
    BUG: 1389293
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/15743
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: jiffin tony Thottan <jthottan>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 3 Worker Ant 2016-11-08 12:39:45 UTC
REVIEW: http://review.gluster.org/15803 (build: Update version check for resource-agents on RHEL) posted (#1) for review on master by soumya k (skoduri)

Comment 4 Worker Ant 2016-11-08 17:30:16 UTC
COMMIT: http://review.gluster.org/15803 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit 3e980c5eff495725e7c01793451bc81fd6f94ad5
Author: Kaleb KEITHLEY <kkeithle>
Date:   Tue Nov 8 15:08:37 2016 +0530

    build: Update version check for resource-agents on RHEL
    
    With bug1302545[1] and bug1303037[2], portblock resource agent
    is made available as part of resource-agents-3.9.5* package
    on RHEL 6.8 and RHEL 7.3 respectively. This change is to
    update the same in the glusterfs spec.
    
    [1] https://bugzilla.redhat.com/show_bug.cgi?id=1302545
    [2] https://bugzilla.redhat.com/show_bug.cgi?id=1303037
    
    Change-Id: I5917e5f22f07b4121d636b099dd8815847e1338f
    BUG: 1389293
    Author:    Kaleb KEITHLEY <kkeithle>
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: http://review.gluster.org/15803
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: jiffin tony Thottan <jthottan>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 5 Kaleb KEITHLEY 2017-01-24 11:51:57 UTC
bug is not relevant after 3.10 branch, fix is on release-3.9 branch

Comment 6 Shyamsundar 2017-03-06 17:31:48 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.