Bug 1401218 - Fix compound fops memory leaks
Summary: Fix compound fops memory leaks
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Krutika Dhananjay
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1401380 1402212
TreeView+ depends on / blocked
 
Reported: 2016-12-03 15:21 UTC by Krutika Dhananjay
Modified: 2017-03-06 17:37 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.10.0
Clone Of:
: 1402212 (view as bug list)
Environment:
Last Closed: 2017-03-06 17:37:56 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Krutika Dhananjay 2016-12-03 15:21:35 UTC
Description of problem:

Nag Pavan Chilakam has reported high consumption of memory with compound fops.
This bug is to track that bug.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2016-12-03 15:23:19 UTC
REVIEW: http://review.gluster.org/16020 (afr, client: More mem-leak fixes in COMPOUND fop cbk) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 2 Worker Ant 2016-12-03 17:05:02 UTC
REVIEW: http://review.gluster.org/16020 (afr, client: More mem-leak fixes in COMPOUND fop cbk) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 3 Worker Ant 2016-12-05 01:28:44 UTC
COMMIT: http://review.gluster.org/16020 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit c89cb610f51e7a5df5c4b7e9378a7ac8ac513e46
Author: Krutika Dhananjay <kdhananj>
Date:   Sat Dec 3 09:09:15 2016 +0530

    afr, client: More mem-leak fixes in COMPOUND fop cbk
    
    Bugs found and fixed:
    1. Use correct subvolume index in pre-op-writev compound cbk
    2. Prevent use-after-free of local->compound_args members in
       compound fops cbk in protocol/client
    3. Fix xdata and xattr leaks in client_process_response
    4. Fix possible leak of xdata in client_pre_writev() in
       test mode.
    5. Free req->compound_req_array.compound_req_array_val as well
       after freeing its members
    6. Free tmp_rsp->flock.lk_owner.lk_owner_val in LK fop.
    
    Change-Id: I15b646d7d4e0e5cd4ea3d2d6452c815cf2eaf68f
    BUG: 1401218
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/16020
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 4 Ravishankar N 2016-12-05 15:47:20 UTC
Sending one more fix.

Comment 5 Worker Ant 2016-12-05 15:47:36 UTC
REVIEW: http://review.gluster.org/16029 (afr: fix bug in passing child index in afr_inode_write_fill) posted (#1) for review on master by Ravishankar N (ravishankar)

Comment 6 Worker Ant 2016-12-06 12:12:04 UTC
COMMIT: http://review.gluster.org/16029 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit ca13525a5de8db745878c4cdf89a45b76a9e62c6
Author: Ravishankar N <ravishankar>
Date:   Mon Dec 5 21:14:57 2016 +0530

    afr: fix bug in passing child index in afr_inode_write_fill
    
    Change-Id: I7b70de317a5f15a3bf483ffe40b971143deddc11
    BUG: 1401218
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/16029
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 7 Shyamsundar 2017-03-06 17:37:56 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.