Hide Forgot
+++ This bug was initially created as a clone of Bug #1401218 +++ Description of problem: Nag Pavan Chilakam has reported high consumption of memory with compound fops. This bug is to track that bug. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: --- Additional comment from Worker Ant on 2016-12-03 10:23:19 EST --- REVIEW: http://review.gluster.org/16020 (afr, client: More mem-leak fixes in COMPOUND fop cbk) posted (#1) for review on master by Krutika Dhananjay (kdhananj) --- Additional comment from Worker Ant on 2016-12-03 12:05:02 EST --- REVIEW: http://review.gluster.org/16020 (afr, client: More mem-leak fixes in COMPOUND fop cbk) posted (#2) for review on master by Krutika Dhananjay (kdhananj) --- Additional comment from Worker Ant on 2016-12-04 20:28:44 EST --- COMMIT: http://review.gluster.org/16020 committed in master by Pranith Kumar Karampuri (pkarampu) ------ commit c89cb610f51e7a5df5c4b7e9378a7ac8ac513e46 Author: Krutika Dhananjay <kdhananj> Date: Sat Dec 3 09:09:15 2016 +0530 afr, client: More mem-leak fixes in COMPOUND fop cbk Bugs found and fixed: 1. Use correct subvolume index in pre-op-writev compound cbk 2. Prevent use-after-free of local->compound_args members in compound fops cbk in protocol/client 3. Fix xdata and xattr leaks in client_process_response 4. Fix possible leak of xdata in client_pre_writev() in test mode. 5. Free req->compound_req_array.compound_req_array_val as well after freeing its members 6. Free tmp_rsp->flock.lk_owner.lk_owner_val in LK fop. Change-Id: I15b646d7d4e0e5cd4ea3d2d6452c815cf2eaf68f BUG: 1401218 Signed-off-by: Krutika Dhananjay <kdhananj> Reviewed-on: http://review.gluster.org/16020 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Pranith Kumar Karampuri <pkarampu> CentOS-regression: Gluster Build System <jenkins.org> --- Additional comment from Ravishankar N on 2016-12-05 10:47:20 EST --- Sending one more fix. --- Additional comment from Worker Ant on 2016-12-05 10:47:36 EST --- REVIEW: http://review.gluster.org/16029 (afr: fix bug in passing child index in afr_inode_write_fill) posted (#1) for review on master by Ravishankar N (ravishankar) --- Additional comment from Worker Ant on 2016-12-06 07:12:04 EST --- COMMIT: http://review.gluster.org/16029 committed in master by Pranith Kumar Karampuri (pkarampu) ------ commit ca13525a5de8db745878c4cdf89a45b76a9e62c6 Author: Ravishankar N <ravishankar> Date: Mon Dec 5 21:14:57 2016 +0530 afr: fix bug in passing child index in afr_inode_write_fill Change-Id: I7b70de317a5f15a3bf483ffe40b971143deddc11 BUG: 1401218 Signed-off-by: Ravishankar N <ravishankar> Reviewed-on: http://review.gluster.org/16029 Reviewed-by: Pranith Kumar Karampuri <pkarampu> Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org>
REVIEW: http://review.gluster.org/16046 (afr, client: More mem-leak fixes in COMPOUND fop cbk) posted (#1) for review on release-3.9 by Krutika Dhananjay (kdhananj)
REVIEW: http://review.gluster.org/16046 (afr, client: More mem-leak fixes in COMPOUND fop cbk) posted (#2) for review on release-3.9 by Krutika Dhananjay (kdhananj)
REVIEW: http://review.gluster.org/16046 (afr, client: More mem-leak fixes in COMPOUND fop cbk) posted (#3) for review on release-3.9 by Krutika Dhananjay (kdhananj)
REVIEW: http://review.gluster.org/16046 (afr, client: More mem-leak fixes in COMPOUND fop cbk) posted (#4) for review on release-3.9 by Krutika Dhananjay (kdhananj)
REVIEW: http://review.gluster.org/16100 (afr: fix bug in passing child index in afr_inode_write_fill) posted (#1) for review on release-3.9 by Krutika Dhananjay (kdhananj)
REVIEW: http://review.gluster.org/16100 (afr: fix bug in passing child index in afr_inode_write_fill) posted (#2) for review on release-3.9 by Krutika Dhananjay (kdhananj)
REVIEW: http://review.gluster.org/16046 (afr, client: More mem-leak fixes in COMPOUND fop cbk) posted (#5) for review on release-3.9 by Krutika Dhananjay (kdhananj)
COMMIT: http://review.gluster.org/16046 committed in release-3.9 by Pranith Kumar Karampuri (pkarampu) ------ commit a8a2d6d3bb161e86464c9bb72b8847fe3ef7699e Author: Krutika Dhananjay <kdhananj> Date: Sat Dec 3 09:09:15 2016 +0530 afr, client: More mem-leak fixes in COMPOUND fop cbk Backport of: http://review.gluster.org/16020 Bugs found and fixed: 1. Use correct subvolume index in pre-op-writev compound cbk 2. Prevent use-after-free of local->compound_args members in compound fops cbk in protocol/client 3. Fix xdata and xattr leaks in client_process_response 4. Fix possible leak of xdata in client_pre_writev() in test mode. 5. Free req->compound_req_array.compound_req_array_val as well after freeing its members 6. Free tmp_rsp->flock.lk_owner.lk_owner_val in LK fop. Change-Id: I40f576b48625d65fcbd7a11181eeff37f9e1e011 BUG: 1402212 Signed-off-by: Krutika Dhananjay <kdhananj> Reviewed-on: http://review.gluster.org/16046 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Pranith Kumar Karampuri <pkarampu>
REVIEW: http://review.gluster.org/16100 (afr: fix bug in passing child index in afr_inode_write_fill) posted (#3) for review on release-3.9 by Krutika Dhananjay (kdhananj)
COMMIT: http://review.gluster.org/16100 committed in release-3.9 by Pranith Kumar Karampuri (pkarampu) ------ commit d92a438350cc30d9961c29fcc696c449790490e4 Author: Ravishankar N <ravishankar> Date: Mon Dec 5 21:14:57 2016 +0530 afr: fix bug in passing child index in afr_inode_write_fill Backport of: http://review.gluster.org/16029 Change-Id: I2589aab4b781cc7b50c93f33c8dc51036dbf82f8 BUG: 1402212 Signed-off-by: Ravishankar N <ravishankar> Reviewed-on: http://review.gluster.org/16100 Tested-by: Krutika Dhananjay <kdhananj> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Pranith Kumar Karampuri <pkarampu>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.1, please open a new bug report. glusterfs-3.9.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/gluster-users/2017-January/029725.html [2] https://www.gluster.org/pipermail/gluster-users/