Bug 1409186 - Dict_t leak in dht_migration_complete_check_task and dht_rebalance_inprogress_task
Summary: Dict_t leak in dht_migration_complete_check_task and dht_rebalance_inprogres...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nithya Balachandran
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1410369 1462066 1462537
TreeView+ depends on / blocked
 
Reported: 2016-12-30 04:56 UTC by Nithya Balachandran
Modified: 2017-06-18 15:55 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.10.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1410369 1462066 1462537 (view as bug list)
Environment:
Last Closed: 2017-03-06 17:41:22 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Nithya Balachandran 2016-12-30 04:56:08 UTC
Description of problem:
Code reading reveals a dictionary leak in both the dht_migration_complete_check_task and  dht_rebalance_inprogress_task functions.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2016-12-30 05:07:15 UTC
REVIEW: http://review.gluster.org/16308 (cluster/dht: Fix dict_leak in migration check tasks) posted (#1) for review on master by N Balachandran (nbalacha)

Comment 2 Worker Ant 2017-01-02 15:30:14 UTC
COMMIT: http://review.gluster.org/16308 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit 11b6a2c9fc5232b58774cab29873406c0fbfef19
Author: N Balachandran <nbalacha>
Date:   Fri Dec 30 10:33:13 2016 +0530

    cluster/dht: Fix dict_leak in migration check tasks
    
    Fixed a memleak where dict was not being unrefed
    in the dht_migration_complete_check_task and
    dht_rebalance_inprogress_task functions.
    
    Change-Id: I3d42e9a2e5c8596c985bf6431a68fd3905227383
    BUG: 1409186
    Signed-off-by: N Balachandran <nbalacha>
    Reviewed-on: http://review.gluster.org/16308
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: MOHIT AGRAWAL <moagrawa>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Shyamsundar 2017-03-06 17:41:22 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.