Description of problem: After updating nagios-plugins this night, all of our checks using the check_file_age-plugins are broken. Version-Release number of selected component (if applicable): 2.1.4-2.el6 Steps to Reproduce: 1. touch /tmp/test 2. /usr/lib64/nagios/plugins/check_file_age -f /tmp/test Actual results: FILE_AGE CRITICAL: File not found - "/tmp/test" Expected results: FILE_AGE OK: /tmp/test is 2 seconds old and 0 bytes | age=2s;240;600 size=0B;0;0;0 Additional info: Upstream added a fix to allow checking of filenames including spaces. However, that fix breaks all filenames which do not include spaces. The upstream bug is discussed here: https://github.com/nagios-plugins/nagios-plugins/issues/213 As the current version break existing checks in a horrible way you might consider of either rolling back to the old version of check_file_age, or fixing this issue downstream (depending on how long upstream needs to fix and push a new release).
Proposed and verified fix is here: https://github.com/nagios-plugins/nagios-plugins/commit/367a44187db1c18a9fd4ba5fafe844f80cbb03c5
*** Bug 1410055 has been marked as a duplicate of this bug. ***
So when is this package going to be fixed in EPEL? Could one of the maintainers just patch in the fix in the SPEC and make a new release? There's no information on when upstream will release a fix, and this check remains broken for all of CentOS 6!
Note this breaks on CentOS 7 too. A simple fix that works for me is to comment out line 80, which quotes the filename: # $opt_f = '"' . $opt_f . '"';
Correction, CentOS 7 seems OK if you're using the stock /usr/bin/perl (the bug only occurs with older Perl).
Hello maintainers, This is a high to urgent severity bug! Could one of you please tell us what you're doing to resolve it? Surely you're not just sitting around waiting for upstream to release a new version? Remember that ALL our Icinga checks are affected by this!!
Need help maintaining nagios* ?
Hi Oden, If your comment was in jest, then I smile :) If you were serious, then I thank you for the offer, but we don't need help. We have applied a sledgehammer fix that has made the file_age plugin work again. It involves deleting the offending line from the plugin, using our config management system (Ansible). Nevertheless, it's additional complexity. In my opinion, a package that BREAKS things, should be very quickly updated. Otherwise it makes us lose faith in auto-updating from EPEL. In my opinion, 9 days to too long. I expected a fix to appear within a couple of days of this report.
(In reply to Anand Buddhdev from comment #8) > Hi Oden, > > If your comment was in jest, then I smile :) > > If you were serious, then I thank you for the offer, but we don't need help. It was aimed at RH EPEL in general. I maintained nagios* for many years in Mandriva Linux and did the mega split of nagios-plugins long before this package was split. Note. Mageia was forked 2010 an the split was done long prior that. https://svnweb.mageia.org/packages/cauldron/nagios-plugins/current/SPECS/nagios-plugins.spec?revision=1078890&view=markup Well.
Hello. Could one of the maintainers please provide an update of what they intend to do to fix this issue?
I am taking this bug and will be putting out a fix as soon as I look over the proposed ones. Oden and Anand, please do me a favor and review the packages at https://copr.fedorainfracloud.org/coprs/smooge/Nagios_Update/ This is where I will be doing the 'fixes' and updated for moving the plugins and other tools. Oden since you helped maintain Nagios for Mandriva I would appreciate any tips and work you can help me with as I am doing this as an "I need to get you guys and myself working"
Stephen, As an FYI, upstream is coming out with an new version that has this and a few others fixed very shortly.
Is there a git repo and commit that I can point to for this?
The upstream commitfix is here: https://github.com/nagios-plugins/nagios-plugins/commit/367a44187db1c18a9fd4ba5fafe844f80cbb03c5
nagios-plugins-2.1.4-3.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-3baea4e0e4
nagios-plugins-2.1.4-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-99cefd5950
nagios-plugins-2.1.4-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-60884752c4
nagios-plugins-2.1.4-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-54fcdfe5a7
*** Bug 1414243 has been marked as a duplicate of this bug. ***
nagios-plugins-2.1.4-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-60884752c4
nagios-plugins-2.1.4-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-54fcdfe5a7
nagios-plugins-2.1.4-3.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-3baea4e0e4
nagios-plugins-2.1.4-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-99cefd5950
nagios-plugins-2.1.4-3.el6 fixes the issue on my system. Thanks!
I also confirm that this -3 release fixes the check_file_age plugin on our CentOS 6 systems. Please release to epel.
nagios-plugins-2.1.4-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
nagios-plugins-2.1.4-5.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-0430ba2927
nagios-plugins-2.1.4-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e7272b1cd
nagios-plugins-2.1.4-5.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-0430ba2927
nagios-plugins-2.1.4-6.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4bf2c82fc6
nagios-plugins-2.1.4-7.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-d35ac726be
nagios-plugins-2.1.4-5.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e7272b1cd
nagios-plugins-2.1.4-7.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-d35ac726be
nagios-plugins-2.2.0-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-cbb077cc9b
nagios-plugins-2.2.0-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-579895db6a
nagios-plugins-2.2.0-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-579895db6a
nagios-plugins-2.2.0-6.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-212f3ef76e
nagios-plugins-2.2.0-6.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-212f3ef76e
nagios-plugins-2.2.0-7.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-756fbbf351
nagios-plugins-2.2.0-7.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-756fbbf351
nagios-plugins-2.2.1-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d5fc1e5e5c
nagios-plugins-2.2.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-e452ab1676
nagios-plugins-2.2.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-e452ab1676
nagios-plugins-2.2.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d5fc1e5e5c
nagios-plugins-2.1.4-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
nagios-plugins-2.2.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
nagios-plugins-2.2.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.