Spec URL: http://scientific.zcu.cz/fedora/rubygem-ruby_engine-1.0.1-1/rubygem-ruby_engine.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-ruby_engine-1.0.1-1/rubygem-ruby_engine-1.0.1-1.fc26.src.rpm Description: Gives you an RubyEngine class that simplifies checking for your Ruby implementation. Fedora Account System Username: valtri COPR build: https://copr.fedorainfracloud.org/coprs/valtri/ruby/build/500696/
Taking. I would appreciate it if you would review my review request (bug 1409288)
Taken, thanks!
Okay, this is also a simple gem based rpm. My request is the same as bug 1414002 . * Exclude files not needed for runtime The following files are not needed and for developing purpose (mainly for test suite). Please consider to remove the below. - %{gem_instdir}/spec/ - %{gem_instdir}/Gemfile - %{gem_instdir}/Gemfile.lock - %{gem_instdir}/Rakefile - %{gem_instdir}/ruby_version.gemspec Otherwise okay.
Just update the %files list, then I can approve this package.
Thanks for the review! Updated: Spec URL: http://scientific.zcu.cz/fedora/rubygem-ruby_engine-1.0.1-2/rubygem-ruby_engine.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-ruby_engine-1.0.1-2/rubygem-ruby_engine-1.0.1-2.fc26.src.rpm %changelog * Mon Jan 23 2017 František Dvořák <valtri.cz> - 1.0.1-2 - Exclude unnecessary files
Okay. * license okay (MIT) * spec file clean * source matches upstream * builds fine * installation fine * rpmlint sane * general functionality okay $ ruby -e 'require "ruby_engine" ; p RubyEngine.is? "ruby"' true ====================================================== This package (rubygem-ruby_engine) is APPROVED by mtasaka ======================================================
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-ruby_engine