Red Hat Bugzilla – Bug 1428340
Xorg killed by SIGABRT after resize of VM display when multiple PCI device in use
Last modified: 2018-10-30 04:02:32 EDT
Description of problem: If display of VM guest is resized, then Xorg is killed by SIGABRT and subsequently Xorg server crashes. Version-Release number of selected component (if applicable): Client/Host: qemu-kvm-1.5.3-132.el7.x86_64 spice-server-0.12.8-1.el7.x86_64 virt-viewer-2.0-13.el7.x86_64 Guest: spice-vdagent-0.14.0-14.el7.x86_64 xorg-x11-drv-qxl-0.1.5-2.el7.x86_64 Kernel: Linux 3.10.0-578.el7.x86_64 How reproducible: always Steps to Reproduce: 1. Boot Guest VM, connect to it with remote-viewer and login to Guest 2. resize window of remote-viewer with Guest Actual results: Xorg killed by SIGABRT. Then either GDM login screen appears or system freezes. Expected results: Resize of guest display without crash. Additional info: see backtrace at attachement
Created attachment 1259087 [details] backtrace
The crash happens only when using multiple pci device (Single PCI checkbox in rhv->edit->Console is not checked)
Please attach /var/log/Xorg.0.log file.
Created attachment 1260730 [details] Xorg log
Created attachment 1261031 [details] patch for xf86-video-qxl possible fix for qxl.
(In reply to Dave Airlie from comment #6) > Created attachment 1261031 [details] > patch for xf86-video-qxl > > possible fix for qxl. Hey Dave, would it be please possible prepare a build that Radek could try? Thanks -Tom
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12711357 is a 7.4 build with the patch from Dave.
Ok I tried the build - it fixes the problem
It looks like it is too late to get into 7.4, but there is a potential fix available. Dave, is this the patch that you think should go upstream?
Pushed upstream as https://cgit.freedesktop.org/xorg/driver/xf86-video-qxl/commit/?id=ee8f904ab0d590c741e640e9548c472e6a58b3cc
(In reply to Jonathon Jongsma from comment #10) > It looks like it is too late to get into 7.4, but there is a potential fix > available. Dave, is this the patch that you think should go upstream? Being not a new feature should not be backported as bugfix anyway?
I would say this started crashing after some Xorg rebase, before Xorg was at least starting up. So fixing that crash would be a bugfix.
Hello. > [0] https://cgit.freedesktop.org/xorg/driver/xf86-video-qxl/commit/ I found this patch works only when qemu-guest-agent in not added to the VM, otherwise crash happens all the times while login. It shows the window which informs that ksmserver is crashed and if to click "okay", it quits to sddm login screen on my Kubuntu 18.04 (dev branch). Also it applies from *ubuntu 16.04.02 till 18.04. Can someone test with qemu-ga added in VM? Thanks.
Hi Eugene, I tested this with rhel7.5 VM with qemu-guest-agent 10:2.8.0-2.el7 installed. 1. Create VM with multiple displays and single multiple PCI 2. start it, connect with remote-viewer and resize guest's display by resizing remote-viewer's window. The crash still happens. Actually - why we do not use patch from comment #8? (https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12711357). It worked for me (as stated in comment #7).
(In reply to Radek Duda from comment #27) > Actually - why we do not use patch from comment #8? > (https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12711357). > It worked for me (as stated in comment #7). Ugh, yes, this missed the cut for 7.5 :-/
(In reply to Radek Duda from comment #27) > Hi Eugene, > > I tested this with rhel7.5 VM with qemu-guest-agent 10:2.8.0-2.el7 > installed. > 1. Create VM with multiple displays and single multiple PCI > 2. start it, connect with remote-viewer and resize guest's display by > resizing remote-viewer's window. > > The crash still happens. > > Actually - why we do not use patch from comment #8? > (https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12711357). > It worked for me (as stated in comment #7). Hello, Radek. Actually I didn't understood you. What did you meant when you first said that crash still happens but then that it worked for you as in state in comment #7 which is telling about attached patch.
there is no crash after resize of VM display now (tested rhel7.6 guest with xorg-x11-drv-qxl-0.1.5-4.el7.1.x86_64)
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:3059