Bug 1460954 - vdsm-client package install fails on older (3.6 compat) nodes
Summary: vdsm-client package install fails on older (3.6 compat) nodes
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-host-deploy
Classification: oVirt
Component: Plugins.VDSM
Version: 1.7.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.2.0
: 1.7.0
Assignee: Sandro Bonazzola
QA Contact: Radim Hrazdil
URL:
Whiteboard:
Depends On:
Blocks: 1478904 1489016
TreeView+ depends on / blocked
 
Reported: 2017-06-13 08:52 UTC by Sahina Bose
Modified: 2017-12-20 10:50 UTC (History)
10 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-20 10:50:53 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: planning_ack+
sbonazzo: devel_ack+
lsvaty: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 78810 0 master MERGED vdsm: fallback on vdsm-cli if vdsm-client is missing 2017-06-29 15:43:55 UTC

Description Sahina Bose 2017-06-13 08:52:38 UTC
Description of problem:

When a node is added to the 3.6 cluster level, installation fails with error message 
Failed to install Host hostnamex. Failed to execute stage 'Package installation': Package vdsm-client cannot be found.

vdsm-client is not available in older vdsm.

Version-Release number of selected component (if applicable):
1.7-master

How reproducible:
Always


Additional info:
Downstream gluster nodes have vdsm 4.17 version and do not have the vdsm-client package.
Is there a way to conditionally check for packages (vdsm-client /vdsm-cli) based on cluster level?

Comment 1 Martin Perina 2017-06-13 09:33:23 UTC
We had a similar discussion in BZ1417687, isn't it possible to use 4.1 host instead of 3.6 one? 4.1 hosts should work fine even in 3.6 clusters ...

Comment 2 Sahina Bose 2017-06-13 10:41:27 UTC
No..The problem is that we want to use oVirt 4.2 to manage older nodes. The only way to do that is to add these to a 3.6 cluster..upgrading the nodes is not an option.
Bug 1443508 was filed to make collectd packages optional to fix the similar issue you mention in Comment 1

Comment 4 Martin Perina 2017-06-13 11:04:36 UTC
(In reply to Sahina Bose from comment #2)
> No..The problem is that we want to use oVirt 4.2 to manage older nodes. The
> only way to do that is to add these to a 3.6 cluster..upgrading the nodes is
> not an option.
> Bug 1443508 was filed to make collectd packages optional to fix the similar
> issue you mention in Comment 1

We for 4.2 we plan to consolidate host dependencies inside ovirt-host package (more details at BZ1460609), but if we really want to fix that issue, we would need to create ovirt-host package also for 3.6 (as those are on different channel than 4.x hosts) and provide 3.6 async with NGN. Sandro?

Comment 7 Sandro Bonazzola 2017-06-14 14:15:03 UTC
(In reply to Martin Perina from comment #4)
> (In reply to Sahina Bose from comment #2)
> > No..The problem is that we want to use oVirt 4.2 to manage older nodes. The
> > only way to do that is to add these to a 3.6 cluster..upgrading the nodes is
> > not an option.
> > Bug 1443508 was filed to make collectd packages optional to fix the similar
> > issue you mention in Comment 1
> 
> We for 4.2 we plan to consolidate host dependencies inside ovirt-host
> package (more details at BZ1460609), but if we really want to fix that
> issue, we would need to create ovirt-host package also for 3.6 (as those are
> on different channel than 4.x hosts) and provide 3.6 async with NGN. Sandro?

Honestly, not sure that a 4.2 feature is worth to be backported to 3.6.
Please note ovirt-host-deploy is not installing vdsm-client directly.
Can you please share the full ovirt-host-deploy log?

Comment 8 Sandro Bonazzola 2017-06-14 14:18:48 UTC
(In reply to Sandro Bonazzola from comment #7)

> Honestly, not sure that a 4.2 feature is worth to be backported to 3.6.
> Please note ovirt-host-deploy is not installing vdsm-client directly.
> Can you please share the full ovirt-host-deploy log?

Actually it is: https://gerrit.ovirt.org/#/c/71235/

Comment 9 Sandro Bonazzola 2017-06-14 14:20:44 UTC
I guess we can just change:
self.packager.installUpdate(('vdsm', 'vdsm-client'))

in
self.packager.installUpdate(('vdsm',))
try:
    self.packager.installUpdate(('vdsm-client',))
except Exception:
    self.packager.installUpdate(('vdsm-cli',))

Not really elegant but should be enough for this legacy handling.

Comment 10 Martin Perina 2017-06-14 14:24:04 UTC
(In reply to Sandro Bonazzola from comment #8)
> (In reply to Sandro Bonazzola from comment #7)
> 
> > Honestly, not sure that a 4.2 feature is worth to be backported to 3.6.
> > Please note ovirt-host-deploy is not installing vdsm-client directly.
> > Can you please share the full ovirt-host-deploy log?
> 
> Actually it is: https://gerrit.ovirt.org/#/c/71235/

Yes, because vdsm-client is a vdsm-cli replacement in 4.1/4.2. So on virt side we are OK with adding 4.1/4.2 hosts into 3.6 cluster without any issues, but this is not an option for gluster, right @Sahina?


(In reply to Sandro Bonazzola from comment #9)
> I guess we can just change:
> self.packager.installUpdate(('vdsm', 'vdsm-client'))
> 
> in
> self.packager.installUpdate(('vdsm',))
> try:
>     self.packager.installUpdate(('vdsm-client',))
> except Exception:
>     self.packager.installUpdate(('vdsm-cli',))
> 
> Not really elegant but should be enough for this legacy handling.

Hmm, wouldn't it be better to create ovirt-host-3.6 with proper dependencies for 3.6 rather then above fix?

Comment 11 Sandro Bonazzola 2017-06-28 11:24:38 UTC
(In reply to Martin Perina from comment #10)

> Hmm, wouldn't it be better to create ovirt-host-3.6 with proper dependencies
> for 3.6 rather then above fix?

We are not releasing anymore packages for 3.6 and 4.0 in oVirt.
So only solution here seems to be comment #9

Comment 12 Oved Ourfali 2017-06-28 12:38:13 UTC
After talking to Sandro, moving to integration team.

Comment 14 Sandro Bonazzola 2017-06-29 15:48:28 UTC
Looks like this affects ovirt-host-deploy 1.7 only, 1.6 (engine 4.1) still install vdsm-cli, not vdsm-client.

Comment 15 Radim Hrazdil 2017-09-07 09:45:31 UTC
Verified that in Version 4.2.0-0.0.master.20170903205106.gitb17261a.el7.centos, installation of 3.6 host to 3.6 cluster succeeds. Vdsm-cli is installed instead of vdsm-client.

Comment 16 Sandro Bonazzola 2017-12-20 10:50:53 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.