Red Hat Bugzilla – Bug 1476819
scripts: invalid test in S32gluster_enable_shared_storage.sh
Last modified: 2017-09-05 13:38:10 EDT
+++ This bug was initially created as a clone of Bug #1476785 +++
Description of problem:
if [ ! "$key" -eq "enable-shared-storage" -o "$key" -eq "cluster.enable-shared-storage" ]; then
man page for test(1) says -eq takes two integer arguments.
The correct syntax should be
if [ "$key" != "enable-shared-storage" -o "$key" = "cluster.enable-shared-storage" ]; then
Or is it supposed to be:
if [ ! ( "$key" = "enable-shared-storage" -o "$key" = "cluster.enable-shared-storage" ) ]; then
Version-Release number of selected component (if applicable):
Steps to Reproduce:
--- Additional comment from Worker Ant on 2017-07-31 09:53:01 EDT ---
REVIEW: https://review.gluster.org/17925 (scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh) posted (#1) for review on master by Kaleb KEITHLEY (email@example.com)
REVIEW: https://review.gluster.org/17926 (scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh) posted (#1) for review on release-3.12 by Kaleb KEITHLEY (firstname.lastname@example.org)
COMMIT: https://review.gluster.org/17926 committed in release-3.12 by Shyamsundar Ranganathan (email@example.com)
Author: Kaleb S. KEITHLEY <firstname.lastname@example.org>
Date: Mon Jul 31 10:22:54 2017 -0400
scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh
test(1) man pages says -eq is for INTEGER compares, and = is for
Also note the comment that -a and -o are ambiguous and to use
test && test or test || test instead.
This bug has existed since 2015! (yikes)
Found while testing localtime logging and running glusterd in the
Signed-off-by: Kaleb S. KEITHLEY <email@example.com>
Smoke: Gluster Build System <firstname.lastname@example.org>
CentOS-regression: Gluster Build System <email@example.com>
Reviewed-by: Shyamsundar Ranganathan <firstname.lastname@example.org>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.
glusterfs-3.12.0 has been announced on the Gluster mailinglists , packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist  and the update infrastructure for your distribution.