+++ This bug was initially created as a clone of Bug #1476785 +++ Description of problem: line 5: if [ ! "$key" -eq "enable-shared-storage" -o "$key" -eq "cluster.enable-shared-storage" ]; then man page for test(1) says -eq takes two integer arguments. The correct syntax should be if [ "$key" != "enable-shared-storage" -o "$key" = "cluster.enable-shared-storage" ]; then Or is it supposed to be: if [ ! ( "$key" = "enable-shared-storage" -o "$key" = "cluster.enable-shared-storage" ) ]; then Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: --- Additional comment from Worker Ant on 2017-07-31 09:53:01 EDT --- REVIEW: https://review.gluster.org/17925 (scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle) --- Additional comment from Worker Ant on 2017-08-01 13:41:29 EDT --- COMMIT: https://review.gluster.org/17925 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 1ae3747608797445c4a59569f93edc331e3626b0 Author: Kaleb S. KEITHLEY <kkeithle> Date: Mon Jul 31 09:48:09 2017 -0400 scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh test(1) man pages says -eq is for INTEGER compares, and = is for string compares. Also note the comment that -a and -o are ambiguous and to use test && test or test || test instead. This bug has existed since 2015! (yikes) Found while testing localtime logging and running glusterd in the foreground. Change-Id: Ia544f7295e247b981504d085ebc4c533ab60ba84 BUG: 1476785 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> Reviewed-on: https://review.gluster.org/17925 Reviewed-by: Niels de Vos <ndevos> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> CentOS-regression: Gluster Build System <jenkins.org>
REVIEW: https://review.gluster.org/17978 (scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh) posted (#1) for review on release-3.10 by Kaleb KEITHLEY (kkeithle)
COMMIT: https://review.gluster.org/17978 committed in release-3.10 by Shyamsundar Ranganathan (srangana) ------ commit 27571cf3cdc83b609bcabf7d0459d61e29abf681 Author: Kaleb S. KEITHLEY <kkeithle> Date: Fri Aug 4 13:27:36 2017 -0400 scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh test(1) man pages says -eq is for INTEGER compares, and = is for string compares. Also note the comment that -a and -o are ambiguous and to use test && test or test || test instead. This bug has existed since 2015! (yikes) Found while testing localtime logging and running glusterd in the foreground. Change-Id: Ia544f7295e247b981504d085ebc4c533ab60ba84 BUG: 1478498 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> Reviewed-on: https://review.gluster.org/17978 Smoke: Gluster Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Nigel Babu <nigelb>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.5, please open a new bug report. glusterfs-3.10.5 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-August/000079.html [2] https://www.gluster.org/pipermail/gluster-users/