+++ This bug was initially created as a clone of Bug #1476785 +++
Description of problem:
if [ ! "$key" -eq "enable-shared-storage" -o "$key" -eq "cluster.enable-shared-storage" ]; then
man page for test(1) says -eq takes two integer arguments; for strings use "=".
Also note the comment in the man page that says -a and -o are ambiguous and use [ foo ] && [ foo ] or [ foo ] || [ foo ]
The correct syntax should be
if [ "$key" != "cluster.enable-shared-storage" ] && [ "$key" != "enable-shared-storage" ]; then
Version-Release number of selected component (if applicable):
Steps to Reproduce:
--- Additional comment from Worker Ant on 2017-07-31 09:53:01 EDT ---
REVIEW: https://review.gluster.org/17925 (scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh) posted (#1) for review on master by Kaleb KEITHLEY (firstname.lastname@example.org)
upstream patch : https://review.gluster.org/#/c/17925/
Build : 3.12.2-8
The test syntax has been updated as mentioned in the description.
Enabling and disabling shared storage succeeded without any issues
Hence marking it as verified.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.