Bug 1477962 - OSP11 -> OSP12 upgrade: Ensure non-controller are usable after upgrade and before converge.
OSP11 -> OSP12 upgrade: Ensure non-controller are usable after upgrade and be...
Status: ON_DEV
Product: Red Hat OpenStack
Classification: Red Hat
Component: rhosp-director (Show other bugs)
12.0 (Pike)
Unspecified Unspecified
unspecified Severity urgent
: ga
: 12.0 (Pike)
Assigned To: marios
Amit Ugol
: Triaged
Depends On:
Blocks: 1477770
  Show dependency treegraph
 
Reported: 2017-08-03 06:35 EDT by Marius Cornea
Modified: 2017-08-18 07:18 EDT (History)
7 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Launchpad 1708115 None None None 2017-08-03 06:35 EDT
OpenStack gerrit 490847 None None None 2017-08-16 08:24 EDT
OpenStack gerrit 490848 None None None 2017-08-16 08:25 EDT
OpenStack gerrit 491749 None None None 2017-08-16 08:25 EDT

  None (edit)
Description Marius Cornea 2017-08-03 06:35:20 EDT
Description of problem:

In the previous iteration we had that mechanism in place https://github.com/openstack/tripleo-heat-templates/blob/master/extraconfig/tasks/tripleo_upgrade_node.sh#L61-L69 for ensure that non-controller node were working after the upgrade and before the converge.

This is especially critical for compute node which should be able to get vm before the convergence step.

For compute node we also have to ensure that rpc pin/unpin happen within the nova_compute container using this parameter UpgradeLevelNovaCompute.
Comment 1 marios 2017-08-16 08:23:58 EDT
Current proposal (duplicated from upstream bug for convenience) and adding the reviews to trackers above

With the help of a utility function in https://review.openstack.org/#/c/491749/ (python-tripleoclient) we can use the upgrade_tasks playbook generated by the tripleo-heat-templates at https://review.openstack.org/#/c/490848/ (note: this depends on a few shardy tht reviews see shortlog).

So, in the upgrade-non-controller.sh script, we add download and execution of both the upgrade_tasks and deploy_steps playbooks with https://review.openstack.org/#/c/490847/ (tripleo-common).

The generated playbooks look like https://paste.fedoraproject.org/paste/gUi5Ckq2qoTT~ed5kItxRw/raw (while it lasts)... seems like most of the things we need for the compute and swift nodes are in the ugprade_tasks (e.g. stop openstack-nova-compute which we had to add recently into the tripleo_upgrade_node.sh).

Reviews:
     (tripleo-common): https://review.openstack.org/#/c/490847/ "Download and run upgrade/deploy_steps_playbooks for upgrade"
     |
     |Depends-On:
     |
     -->(tripleo-heat-templates): https://review.openstack.org/#/c/490848/ "Also write an upgrade_(batch)_tasks playbook" (&see shortlog!)
        |
        |Depends-On:
        |
        -->(python-tripleo-client): https://review.openstack.org/#/c/491749/ "Adds when in upgrade_tasks playbook written by config download"

Note You need to log in before you can comment on or make changes to this bug.