Bug 1482923 - afr: check op_ret value in __afr_selfheal_name_impunge
Summary: afr: check op_ret value in __afr_selfheal_name_impunge
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ravishankar N
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1487319 1491995
TreeView+ depends on / blocked
 
Reported: 2017-08-18 12:35 UTC by Ravishankar N
Modified: 2017-12-08 17:38 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.13.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1487319 1491995 (view as bug list)
Environment:
Last Closed: 2017-12-08 17:38:25 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Description Ravishankar N 2017-08-18 12:35:39 UTC
Comment 1 Worker Ant 2017-08-18 12:37:39 UTC 
REVIEW: https://review.gluster.org/18065 (afr: check op_ret value in __afr_selfheal_name_impunge) posted (#1) for review on master by Ravishankar N (ravishankar)
Comment 2 Worker Ant 2017-08-18 12:41:28 UTC 
REVIEW: https://review.gluster.org/18065 (afr: check op_ret value in __afr_selfheal_name_impunge) posted (#2) for review on master by Ravishankar N (ravishankar)
Comment 3 Worker Ant 2017-08-19 11:31:23 UTC 
REVIEW: https://review.gluster.org/18065 (afr: check validity of afr_reply) posted (#3) for review on master by Ravishankar N (ravishankar)
Comment 4 Worker Ant 2017-08-27 04:16:20 UTC 
REVIEW: https://review.gluster.org/18065 (afr: check validity of afr_reply) posted (#4) for review on master by Ravishankar N (ravishankar)
Comment 5 Worker Ant 2017-08-30 16:10:58 UTC 
REVIEW: https://review.gluster.org/18065 (afr: check validity of afr_reply) posted (#5) for review on master by Ravishankar N (ravishankar)
Comment 6 Worker Ant 2017-08-31 09:41:02 UTC 
COMMIT: https://review.gluster.org/18065 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit d594900dbca92c356152be65fce16f77c402117c
Author: Ravishankar N <ravishankar>
Date:   Fri Aug 18 18:05:54 2017 +0530

    afr: check validity of afr_reply
    
    ...in various self-heal code paths.
    
    Originally found by Pranith in __afr_selfheal_name_impunge ()
    
    Also change __afr_selfheal_assign_gfid() to send lookup only on those
    bricks that don't have a gfid matching that of the source.
    
    Change-Id: I70a2ccd750a2af92c5fc36e0eefb2b6125404b4a
    BUG: 1482923
    Signed-off-by: Pranith Kumar K <pkarampu>
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: https://review.gluster.org/18065
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
Comment 7 Shyamsundar 2017-12-08 17:38:25 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/
Note You need to log in before you can comment on or make changes to this bug.