Bug 1491995 - afr: check op_ret value in __afr_selfheal_name_impunge
Summary: afr: check op_ret value in __afr_selfheal_name_impunge
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: 3.10
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ravishankar N
QA Contact:
URL:
Whiteboard:
Depends On: 1482923
Blocks: 1487319
TreeView+ depends on / blocked
 
Reported: 2017-09-15 08:51 UTC by Ravishankar N
Modified: 2017-10-06 17:11 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.10.6
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1482923
Environment:
Last Closed: 2017-10-06 17:11:53 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ravishankar N 2017-09-15 08:51:55 UTC
+++ This bug was initially created as a clone of Bug #1482923 +++



--- Additional comment from Worker Ant on 2017-08-18 08:37:39 EDT ---

REVIEW: https://review.gluster.org/18065 (afr: check op_ret value in __afr_selfheal_name_impunge) posted (#1) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-08-18 08:41:28 EDT ---

REVIEW: https://review.gluster.org/18065 (afr: check op_ret value in __afr_selfheal_name_impunge) posted (#2) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-08-19 07:31:23 EDT ---

REVIEW: https://review.gluster.org/18065 (afr: check validity of afr_reply) posted (#3) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-08-27 00:16:20 EDT ---

REVIEW: https://review.gluster.org/18065 (afr: check validity of afr_reply) posted (#4) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-08-30 12:10:58 EDT ---

REVIEW: https://review.gluster.org/18065 (afr: check validity of afr_reply) posted (#5) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-08-31 05:41:02 EDT ---

COMMIT: https://review.gluster.org/18065 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit d594900dbca92c356152be65fce16f77c402117c
Author: Ravishankar N <ravishankar>
Date:   Fri Aug 18 18:05:54 2017 +0530

    afr: check validity of afr_reply
    
    ...in various self-heal code paths.
    
    Originally found by Pranith in __afr_selfheal_name_impunge ()
    
    Also change __afr_selfheal_assign_gfid() to send lookup only on those
    bricks that don't have a gfid matching that of the source.
    
    Change-Id: I70a2ccd750a2af92c5fc36e0eefb2b6125404b4a
    BUG: 1482923
    Signed-off-by: Pranith Kumar K <pkarampu>
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: https://review.gluster.org/18065
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2017-09-15 08:52:52 UTC
REVIEW: https://review.gluster.org/18303 (afr: check validity of afr_reply) posted (#1) for review on release-3.10 by Ravishankar N (ravishankar)

Comment 2 Worker Ant 2017-09-17 12:53:28 UTC
COMMIT: https://review.gluster.org/18303 committed in release-3.10 by Shyamsundar Ranganathan (srangana) 
------
commit 4d121709766c10bdb7900dd9066dcec5b16678c3
Author: Ravishankar N <ravishankar>
Date:   Fri Aug 18 18:05:54 2017 +0530

    afr: check validity of afr_reply
    
    ...in various self-heal code paths.
    
    Originally found by Pranith in __afr_selfheal_name_impunge ()
    
    Also change __afr_selfheal_assign_gfid() to send lookup only on those
    bricks that don't have a gfid matching that of the source.
    
    > Reviewed-on: https://review.gluster.org/18065
    > Smoke: Gluster Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    (cherry picked from commit d594900dbca92c356152be65fce16f77c402117c)
    Change-Id: I70a2ccd750a2af92c5fc36e0eefb2b6125404b4a
    BUG: 1491995
    Signed-off-by: Pranith Kumar K <pkarampu>
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: https://review.gluster.org/18303
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Shyamsundar 2017-10-06 17:11:53 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.6, please open a new bug report.

glusterfs-3.10.6 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-October/000084.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.