Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1487319

Summary:	afr: check op_ret value in __afr_selfheal_name_impunge
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	replicate	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.12	CC:	bugs, jthottan
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-glusterfs-3.12.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1482923	Environment:
Last Closed:	2017-09-14 07:42:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1482923, 1491995
Bug Blocks:	1488560

Description Ravishankar N 2017-08-31 15:38:55 UTC

+++ This bug was initially created as a clone of Bug #1482923 +++



--- Additional comment from Worker Ant on 2017-08-18 08:37:39 EDT ---

REVIEW: https://review.gluster.org/18065 (afr: check op_ret value in __afr_selfheal_name_impunge) posted (#1) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-08-18 08:41:28 EDT ---

REVIEW: https://review.gluster.org/18065 (afr: check op_ret value in __afr_selfheal_name_impunge) posted (#2) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-08-19 07:31:23 EDT ---

REVIEW: https://review.gluster.org/18065 (afr: check validity of afr_reply) posted (#3) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-08-27 00:16:20 EDT ---

REVIEW: https://review.gluster.org/18065 (afr: check validity of afr_reply) posted (#4) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-08-30 12:10:58 EDT ---

REVIEW: https://review.gluster.org/18065 (afr: check validity of afr_reply) posted (#5) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-08-31 05:41:02 EDT ---

COMMIT: https://review.gluster.org/18065 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit d594900dbca92c356152be65fce16f77c402117c
Author: Ravishankar N <ravishankar>
Date:   Fri Aug 18 18:05:54 2017 +0530

    afr: check validity of afr_reply
    
    ...in various self-heal code paths.
    
    Originally found by Pranith in __afr_selfheal_name_impunge ()
    
    Also change __afr_selfheal_assign_gfid() to send lookup only on those
    bricks that don't have a gfid matching that of the source.
    
    Change-Id: I70a2ccd750a2af92c5fc36e0eefb2b6125404b4a
    BUG: 1482923
    Signed-off-by: Pranith Kumar K <pkarampu>
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: https://review.gluster.org/18065
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2017-08-31 15:39:52 UTC

REVIEW: https://review.gluster.org/18173 (afr: check validity of afr_reply) posted (#1) for review on release-3.12 by Ravishankar N (ravishankar)

Comment 2 Worker Ant 2017-09-07 06:46:23 UTC

COMMIT: https://review.gluster.org/18173 committed in release-3.12 by jiffin tony Thottan (jthottan) 
------
commit e6aaeda4c3a44f1c459adbd619ee7c6d0151b254
Author: Ravishankar N <ravishankar>
Date:   Fri Aug 18 18:05:54 2017 +0530

    afr: check validity of afr_reply
    
    ...in various self-heal code paths.
    
    Originally found by Pranith in __afr_selfheal_name_impunge ()
    
    Also change __afr_selfheal_assign_gfid() to send lookup only on those
    bricks that don't have a gfid matching that of the source.
    
    
    > Reviewed-on: https://review.gluster.org/18065
    > Smoke: Gluster Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    (cherry picked from commit d594900dbca92c356152be65fce16f77c402117c)
    
    Change-Id: I70a2ccd750a2af92c5fc36e0eefb2b6125404b4a
    BUG: 1487319
    Signed-off-by: Pranith Kumar K <pkarampu>
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: https://review.gluster.org/18173
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 3 Jiffin 2017-09-14 07:42:56 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-glusterfs-3.12.1, please open a new bug report.

glusterfs-glusterfs-3.12.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-September/032441.html
[2] https://www.gluster.org/pipermail/gluster-users/