Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1501472

Summary: Invalid ssh configuration is generated on compute nodes when hieradata is invalid
Product: Red Hat OpenStack Reporter: Ollie Walsh <owalsh>
Component: openstack-tripleo-heat-templatesAssignee: Ollie Walsh <owalsh>
Status: CLOSED CURRENTRELEASE QA Contact: Gurenko Alex <agurenko>
Severity: medium Docs Contact:
Priority: medium    
Version: 10.0 (Newton)CC: agurenko, jjoyce, lyarwood, mbooth, mburns, mschuppe, rhel-osp-director-maint
Target Milestone: ---Keywords: Triaged, ZStream
Target Release: 10.0 (Newton)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: puppet-tripleo-5.6.4-1.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1466879 Environment:
Last Closed: 2018-07-09 14:53:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1466879, 1501473    
Bug Blocks: 1464504, 1501470, 1501471, 1539769, 1539770    

Description Ollie Walsh 2017-10-12 15:36:32 UTC 
+++ This bug was initially created as a clone of Bug #1466879 +++

Description of problem:
If either NovaLibvirtNetwork or NovaColdMigrationNetwork is missing from ServiceNetMap, IPs are missing from the hieradata, which results in an invalid sshd_config on compute nodes.

Version-Release number of selected component (if applicable):
openstack-tripleo-heat-templates-2.0.0-55.el7ost

How reproducible:
I could not reproduce but this.

Actual results:
SSH to compute nodes fails until the missing value are add and the stack is updated.

Expected results:
Validation should chatch the bad input and fail immediately instead of modified the sshd_config.

Additional info:
Forked from https://bugzilla.redhat.com/show_bug.cgi?id=1463680
Comment 1 Martin Schuppert 2018-07-09 14:53:14 UTC 
Fix already released for OSP10:

* Tue Oct 24 2017 Jason Joyce <jjoyce> 5.6.4-1
- Handle duplicate/invalid entries in migration SSH inbound addresses
- Disable SSH login for nova_migration user when migration over ssh is disabled.
- Update to 5.6.4

Current latest is 5.6.8-7.