Description of problem:

If the network name is greater than 15 characters, the original name of the network will be converted into a different name. So the bridge and libvirt networks will be created with this name.

However, the display parameters of the VMs xml is still passed with the original name instead of  "vdsmName".

In the test below the original network name is TEST-RHV-TEST-MGMTNTWRK and vdsmName is vdsm-on26fe7839b6cc4.

displayNetwork is  passed as TEST-RHV-TEST-MGMTNTWRK

2018-05-04 13:04:47,865-04 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.CreateVDSCommand] (org.ovirt.thread.pool-6-thread-30) [d9e55245-9830-4a41-ad27-1f6cdbc3a37d] VM {memGuaranteedSize=256, smpThreadsPerCore=1, cpuType=Haswell-noTSX, vmId=ae1fa9b0-c42d-47ba-a966-6ff7c7afa0e7, acpiEnable=true, vmType=kvm, smp=1, smpCoresPerSocket=1, emulatedMachine=pc-i440fx-rhel7.3.0, smartcardEnable=false, guestNumaNodes=[{memory=512, cpus=0, nodeIndex=0}], transparentHugePages=true, displayNetwork=TEST-RHV-TEST-MGMTNTWRK, vmName=test_vm, .....display=qxl, timeOffset=0, nice=0, maxMemSize=2048, maxMemSlots=16, bootMenuEnable=false, memSize=512}


In the vdsm log.

        <graphics autoport="yes" defaultMode="secure" passwd="*****" passwdValidTo="1970-01-01T00:00:01" port="-1" tlsPort="-1" type="spice">
            <channel mode="secure" name="main" />
            <channel mode="secure" name="inputs" />
            <channel mode="secure" name="cursor" />
            <channel mode="secure" name="playback" />
            <channel mode="secure" name="record" />
            <channel mode="secure" name="display" />
            <channel mode="secure" name="smartcard" />
            <channel mode="secure" name="usbredir" />
            <listen network="vdsm-TEST-RHV-TEST-MGMTNTWRK" type="network" />
        </graphics>

Because of this, VM will fail to start with the error below.

2018-05-04 22:34:48,963+0530 ERROR (vm/ae1fa9b0) [virt.vm] (vmId='ae1fa9b0-c42d-47ba-a966-6ff7c7afa0e7') The vm start process failed (vm:632)
Traceback (most recent call last):
  File "/usr/share/vdsm/virt/vm.py", line 563, in _startUnderlyingVm
    self._run()
  File "/usr/share/vdsm/virt/vm.py", line 2021, in _run
    self._connection.createXML(domxml, flags),
  File "/usr/lib/python2.7/site-packages/vdsm/libvirtconnection.py", line 123, in wrapper
    ret = f(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/vdsm/utils.py", line 941, in wrapper
    return func(inst, *args, **kwargs)
  File "/usr/lib64/python2.7/site-packages/libvirt.py", line 3777, in createXML
    if ret is None:raise libvirtError('virDomainCreateXML() failed', conn=self)
libvirtError: Network not found: no network with matching name 'vdsm-TEST-RHV-TEST-MGMTNTWRK'

The libvirt network is created as vdsm-on26fe7839b6cc4 and not vdsm-TEST-RHV-TEST-MGMTNTWRK.

virsh -r net-list
 Name                 State      Autostart     Persistent
----------------------------------------------------------
 ;vdsmdummy;          active     no            no
 vdsm-on26fe7839b6cc4 active     yes           yes
 vdsm-ovirtmgmt       active     yes           yes

The same issue happens in 4.2 as well but it fails before it reaches to libvirtd. Below is logged in vdsm on 4.2.


2018-05-04 19:46:57,591+0530 ERROR (vm/a3275b32) [virt.vm] (vmId='a3275b32-8ec7-4a03-966d-ead19d89e1d0') Failed to setup device spice (vm:2617)
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/vdsm/virt/vm.py", line 2614, in _setup_devices
    dev_object.setup()
  File "/usr/lib/python2.7/site-packages/vdsm/virt/vmdevices/graphics.py", line 92, in setup
    displaynetwork.create_network(display_network, self.vmid)
  File "/usr/lib/python2.7/site-packages/vdsm/virt/displaynetwork.py", line 26, in create_network
    display_device = _display_device(netname)
  File "/usr/lib/python2.7/site-packages/vdsm/virt/displaynetwork.py", line 35, in _display_device
    return net_api.network_northbound(netname)
  File "/usr/lib/python2.7/site-packages/vdsm/network/api.py", line 100, in network_northbound
    return netswitch.configurator.net2northbound(network_name)
  File "/usr/lib/python2.7/site-packages/vdsm/network/netswitch/configurator.py", line 438, in net2northbound
    is_legacy = net_attr['switch'] == legacy_switch.SWITCH_TYPE
TypeError: 'NoneType' object has no attribute '__getitem__'


Version-Release number of selected component (if applicable):

rhevm-4.1.11.2-0.1.el7.noarch

How reproducible:

100%

Steps to Reproduce:

Create a display network which is having characters greater than 15 characters and start the VM o this cluster.


Actual results:

Wrong network name is passed to the vdsm for the display parameter.

Expected results:

Pass correct information to the vdsm.

Additional info: