Description of problem: The source of gnuradio contains both decoders and encoders for dvb-t, dvb-t2 (for data streams, not for codecs) and maybe more. These components are possibly patented and thus not allowed in fedora. Version-Release number of selected component (if applicable): gnuradio-3.7.13.3-3.fc28
List of patents applying to DVB-T: http://www.sisvel.com/DVB-T/Patents.pdf List of patents applying to DVB-T2: http://www.sisvel.com/DVB-T2/Patents.pdf
Github link to dvb-t sources: https://github.com/gnuradio/gnuradio/tree/master/gr-dtv/lib/dvbt Github link to dvb-t2 sources: https://github.com/gnuradio/gnuradio/tree/master/gr-dtv/lib/dvbt2 Other possibly patented decoders/encoders: dvb - https://github.com/gnuradio/gnuradio/tree/master/gr-dtv/lib/dvb note: used in other dvb decoders/encoders? atsc - https://github.com/gnuradio/gnuradio/tree/master/gr-dtv/lib/atsc https://github.com/gnuradio/gnuradio/tree/master/gr-atsc note: https://www.atsc.org/policies/patent-statements/
Okay. DVB-T2 and ATSC support needs to come entirely out of the Fedora package. Everything seems to have expired for DVB-T, so it could stay, but I'm not sure if keeping the gr-dtv module in Fedora without ATSC and DVB-T2 is the right decision. It seems like removing gr-atsc and gr-drv and then making rpmfusion packages for them would provide a better user experience. Jaroslav, I'll let you decide exactly how you want to do this, but the source tarball needs to be "clean", which means that the gr-atsc/ directory and the gr-dtv/lib/[atsc|dvbt2] directories need to be removed entirely. Note: I did a local test build removing gr-atsc/ and the gr-dtv/lib/[atsc|dvbt2] directories, and it succeeded, but I don't know if it actually works or not.
Created attachment 1471262 [details] cleaning script An shell script to clean the tarball of patented content
Jaroslav? If you don't take care of this soon, I will do it for you.
(In reply to Tom "spot" Callaway from comment #5) > Jaroslav? If you don't take care of this soon, I will do it for you. Sorry for delay, I will try to resolve it today.
(In reply to Tom "spot" Callaway from comment #3) > Okay. DVB-T2 and ATSC support needs to come entirely out of the Fedora > package. Everything seems to have expired for DVB-T, so it could stay, but > I'm not sure if keeping the gr-dtv module in Fedora without ATSC and DVB-T2 > is the right decision. It seems like removing gr-atsc and gr-drv and then > making rpmfusion packages for them would provide a better user experience. > > Jaroslav, I'll let you decide exactly how you want to do this, but the > source tarball needs to be "clean", which means that the gr-atsc/ directory > and the gr-dtv/lib/[atsc|dvbt2] directories need to be removed entirely. > > Note: I did a local test build removing gr-atsc/ and the > gr-dtv/lib/[atsc|dvbt2] directories, and it succeeded, but I don't know if > it actually works or not. Is it needed to repack the tarball, or is it enough to drop the patented content in the %prep phase?
You need to repack the tarball.
Thanks for info, building the test build now.
(In reply to Dave Olsthoorn from comment #4) > Created attachment 1471262 [details] > cleaning script > > An shell script to clean the tarball of patented content Thanks for the script :)
I opened upstream bug: https://github.com/gnuradio/gnuradio/issues/1948
It's in the dist-git, but not build. I cannot build it on s390x due to bug 1614512.