Description of problem:
Migration plan CSV import validation not working if file contain empty/archived/orphan/invalid vm
Version-Release number of selected component (if applicable):
Steps to Reproduce:
Earlier when file had empty/archived/orphan/invalid vm, that file was getting validated and we were getting disable checkbox in-front of that vm. That was helpful to understand why vm is ignored. Currently we are not able to proceed to next tab when we have mentioned type of vm.
CSV import should work as earlier
Created attachment 1554789 [details]
YTale, thanks for catching this. When I added the VMWare Folder View feature (https://bugzilla.redhat.com/show_bug.cgi?id=1593839) I wrote code that assumes VM objects from validation/discovery will always have a defined "path" property, but invalid CSV rows do not. The tests for that code did not include invalid CSV rows.
I've fixed the regression in this PR: https://github.com/ManageIQ/manageiq-v2v/pull/932
The PR also adds a better unit test for this case.
Verified on: 126.96.36.199