Bug 1699574 - psi - remove minizip-compat dependency
Summary: psi - remove minizip-compat dependency
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: psi
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Vitaly
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1632193
Blocks: 1632194 1632208
TreeView+ depends on / blocked
 
Reported: 2019-04-13 19:07 UTC by Raphael Groner
Modified: 2021-02-20 13:31 UTC (History)
7 users (show)

Fixed In Version:
Clone Of: 1632194
Environment:
Last Closed: 2021-02-20 13:31:06 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github psi-im psi issues 388 0 None open Port against maintained minizip 2021-02-20 13:20:27 UTC

Description Raphael Groner 2019-04-13 19:07:38 UTC
+++ This bug was initially created as a clone of Bug #1632194 +++

I intend to remove unmaintained minizip library (now packaged as minizip-compat) from the zlib package. Therefore, I'd need all dependent packages to either migrate to the new minizip[1] package or simply bundle the old one.

[1] https://github.com/nmoinvaz/minizip

--- Additional comment from Raphael Groner on 2018-09-24 20:42:43 CEST ---

You did that change by yourself. Please undo also.

https://src.fedoraproject.org/rpms/psi-plus/c/94ac1caaff7a20f25a42de4dacadfd0d013c3b55?branch=master

--- Additional comment from Patrik Novotný on 2018-09-25 17:05:35 CEST ---

I'll try to clarify the situation.

What happened is that I renamed the minizip package (part of zlib) to minizip-compat. Then a new minizip package build from maintained fork of the original minizip library has been introduced.

In the commit you're referring to I'm only preserving the dependency on the old minizip - now packaged as minizip-compat. So this change is only cosmetic and the functionality is unchanged.

The subject of this BZ is to actually change the dependency to the new minizip package. Either by porting psi-plus or by bundling the old minizip.

The intent is to remove the old minizip library from the zlib package (now minizip-compat).

--- Additional comment from Raphael Groner on 2018-12-17 16:02:01 CET ---

Please can you file a PR? I could review and apply.
Sorry for the long delay.

--- Additional comment from Raphael Groner on 2019-01-15 18:12:32 CET ---

Sorry, I still fail to see an issue. There's no FTBFS in rawhide and I don't know what to fix.
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=32047025

Please feel free to reopen this bug if you think there's still an issue.

--- Additional comment from Raphael Groner on 2019-01-15 18:13:41 CET ---

https://src.fedoraproject.org/rpms/psi-plus/c/94ac1caaff7a20f25a42de4dacadfd0d013c3b55?branch=master

Maybe?

--- Additional comment from Raphael Groner on 2019-04-09 21:27:51 CEST ---

psi-plus version 1.4 successfully builds with separate minizip package as dependency.
No idea why there wasn't any change done in F29. Reverting your commit with the next build.

--- Additional comment from Raphael Groner on 2019-04-10 19:47:54 CEST ---

https://pagure.io/fedora-infrastructure/issue/7704#comment-565477

--- Additional comment from Raphael Groner on 2019-04-13 20:53:14 CEST ---

Right, this should get fixed by upstream. Why isn't a new minizip pkg available in F29?
https://src.fedoraproject.org/rpms/psi/blob/master/f/psi.spec#_38

--- Additional comment from Raphael Groner on 2019-04-13 21:01:59 CEST ---

Filed to upstream.

Comment 1 Raphael Groner 2019-04-13 19:08:57 UTC
We'd consider to unbundle libpsi into another package. libpsi is used for both psi and psi-plus as well provided as a separate project in upstream. I'll file another bug about that issue.

Comment 2 Vitaly 2019-04-13 19:35:24 UTC
I already removed minizip-compat dependency. Psi use bundled version for F30 and above.

Comment 3 Raphael Groner 2019-04-13 19:46:22 UTC
Well, in Fedora we prefer to unbundle as best as we can.

Comment 4 Vitaly 2019-04-13 19:48:40 UTC
I think we need to ask Psi upstream to switch to maintained version of minizip library.

Comment 5 Raphael Groner 2019-04-13 19:54:13 UTC
Upstream refuses.

Comment 6 Raphael Groner 2019-04-16 04:43:48 UTC
Maybe you'd request to get the new main admin of this package.

Comment 7 Ben Cotton 2019-08-13 16:51:30 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 8 Ben Cotton 2019-08-13 19:27:35 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 9 Vitaly 2021-02-20 13:31:06 UTC
Psi is already using its own bundled minizip. It has no depencency on minizip-compat-devel anymore.


Note You need to log in before you can comment on or make changes to this bug.