Bug 1632194 - psi-plus - remove minizip-compat dependency
Summary: psi-plus - remove minizip-compat dependency
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: psi-plus
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vitaly
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/psi-im/psi/issues/388
Whiteboard:
Depends On: 1699574 1699575
Blocks: 1632208
TreeView+ depends on / blocked
 
Reported: 2018-09-24 10:46 UTC by Patrik Novotný
Modified: 2021-02-20 13:32 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
: 1699574 (view as bug list)
Environment:
Last Closed: 2021-02-20 13:32:52 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github psi-im libpsi issues 13 0 None None None 2020-07-22 14:12:53 UTC
Github psi-im psi issues 388 0 None open Port against maintained minizip 2021-02-20 13:15:43 UTC

Description Patrik Novotný 2018-09-24 10:46:20 UTC
I intend to remove unmaintained minizip library (now packaged as minizip-compat) from the zlib package. Therefore, I'd need all dependent packages to either migrate to the new minizip[1] package or simply bundle the old one.

[1] https://github.com/nmoinvaz/minizip

Comment 1 Raphael Groner 2018-09-24 18:42:43 UTC
You did that change by yourself. Please undo also.

https://src.fedoraproject.org/rpms/psi-plus/c/94ac1caaff7a20f25a42de4dacadfd0d013c3b55?branch=master

Comment 2 Patrik Novotný 2018-09-25 15:05:35 UTC
I'll try to clarify the situation.

What happened is that I renamed the minizip package (part of zlib) to minizip-compat. Then a new minizip package build from maintained fork of the original minizip library has been introduced.

In the commit you're referring to I'm only preserving the dependency on the old minizip - now packaged as minizip-compat. So this change is only cosmetic and the functionality is unchanged.

The subject of this BZ is to actually change the dependency to the new minizip package. Either by porting psi-plus or by bundling the old minizip.

The intent is to remove the old minizip library from the zlib package (now minizip-compat).

Comment 3 Raphael Groner 2018-12-17 15:02:01 UTC
Please can you file a PR? I could review and apply.
Sorry for the long delay.

Comment 4 Raphael Groner 2019-01-15 17:12:32 UTC
Sorry, I still fail to see an issue. There's no FTBFS in rawhide and I don't know what to fix.
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=32047025

Please feel free to reopen this bug if you think there's still an issue.

Comment 6 Raphael Groner 2019-04-09 19:27:51 UTC
psi-plus version 1.4 successfully builds with separate minizip package as dependency.
No idea why there wasn't any change done in F29. Reverting your commit with the next build.

Comment 8 Raphael Groner 2019-04-13 18:53:14 UTC
Right, this should get fixed by upstream. Why isn't a new minizip pkg available in F29?
https://src.fedoraproject.org/rpms/psi/blob/master/f/psi.spec#_38

Comment 9 Raphael Groner 2019-04-13 19:01:59 UTC
Filed to upstream.

Comment 10 Raphael Groner 2019-04-13 19:50:28 UTC
Upstream refuses to unbundle with the reasons given there in the issue.
https://github.com/psi-im/libpsi/issues/13

Comment 11 Raphael Groner 2019-04-14 06:17:09 UTC
Main discussion: https://github.com/psi-im/psi/issues/388

Comment 12 Ben Cotton 2019-08-13 17:11:27 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 13 Ben Cotton 2019-08-13 18:53:50 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 14 Raphael Groner 2020-07-22 14:14:08 UTC
new maintainer.

Comment 15 Vitaly 2021-02-20 13:32:52 UTC
Psi-plus is already uses its own bundled minizip. It has no depencency on minizip-compat-devel anymore.


Note You need to log in before you can comment on or make changes to this bug.