Bug 1699575 - psi: unbundle libpsi due to it's a separate project
Summary: psi: unbundle libpsi due to it's a separate project
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: psi
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Vitaly
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1632194 1709016
TreeView+ depends on / blocked
 
Reported: 2019-04-13 19:13 UTC by Raphael Groner
Modified: 2021-02-20 13:28 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-02-20 13:28:33 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Raphael Groner 2019-04-13 19:13:51 UTC
Description of problem:
We'd consider to unbundle libpsi into another package. libpsi is used for both psi and psi-plus as well provided as a separate project in upstream.

Version-Release number of selected component (if applicable):
-

How reproducible:
yes

Steps to Reproduce:
1. dnf install psi
2. dnf install psi-plus
3.

Actual results:
Both packages psi and psi-plus are build with bundled libpsi.

Expected results:
libpsi get's installed as a separate package.

Additional info:
https://github.com/psi-im/libpsi

Comment 1 Raphael Groner 2019-04-13 19:15:07 UTC
Especially, libpsi has bundled minizip. There's now a fork of minizip independently from zlib as the legacy home project.

Comment 2 Vitaly 2019-04-13 19:39:38 UTC
Someone need to package it first.

Comment 3 Raphael Groner 2019-04-13 19:58:37 UTC
(In reply to Vitaly Zaitsev from comment #2)
> Someone need to package it first.

Maybe later when the minizip issue is fixed.

Comment 4 Raphael Groner 2019-04-13 19:59:59 UTC
Well, maybe psi could provide libpsi as a subpackage?

Comment 5 Vitaly 2019-04-13 20:10:09 UTC
> Well, maybe psi could provide libpsi as a subpackage?

This is a new separate project. It must follow standard package review procedure.

Comment 6 Raphael Groner 2019-04-13 20:11:38 UTC
(In reply to Vitaly Zaitsev from comment #5)
> > Well, maybe psi could provide libpsi as a subpackage?
> 
> This is a new separate project. It must follow standard package review
> procedure.

Hmm, psi-plus builds are from the snapshots project to get all sources and patches.

Comment 7 Ben Cotton 2019-08-13 17:02:47 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 8 Ben Cotton 2019-08-13 19:27:37 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 9 Vitaly 2020-06-04 09:02:09 UTC
Upstream developer said that it is absolutely impossible to provide libpsi as a separate shared library.

Comment 10 Raphael Groner 2020-06-04 10:46:58 UTC
No, please keep this bug open. It's an obvious violation of our policy to unbundle in Fedora (downstream).

Take care about the conflict between having a common library (libpsi) and patch it in each project individually!

Comment 11 Vitaly 2020-06-04 12:20:47 UTC
> It's an obvious violation of our policy to unbundle in Fedora (downstream).

Bundling does not violates any Fedora policies nowadays. Feel free to bundle anything you need after adding Provides: bundled() in SPEC. You don't even need to request FESCo exceptions for doing this.

Comment 12 Raphael Groner 2020-06-04 13:51:01 UTC
(In reply to Vitaly Zaitsev from comment #11)
> > It's an obvious violation of our policy to unbundle in Fedora (downstream).
> 
> Bundling does not violates any Fedora policies nowadays. Feel free to bundle
> anything you need after adding Provides: bundled() in SPEC. You don't even
> need to request FESCo exceptions for doing this.

That's well known for the general process. But I fail to see why upstream refused to implement.

Comment 13 Vitaly 2020-06-04 15:21:29 UTC
> That's well known for the general process. But I fail to see why upstream refused to implement.

Because it will be very difficult to maintain API and ABI compatibility.

Comment 14 Raphael Groner 2020-06-04 15:46:39 UTC
Trying to find the relevant differences between psi/libpsi and psi-plus/libpsi folders.

Why doesn't give me any output for spectool -g psi.spec? It works for psi-plus.spec though.

psi-plus.spec delivers snapshot only, psi.spec is responsible to deliver all sources.

Comment 15 Raphael Groner 2020-06-04 15:48:54 UTC
(In reply to Vitaly Zaitsev from comment #13)
> > That's well known for the general process. But I fail to see why upstream refused to implement.
> 
> Because it will be very difficult to maintain API and ABI compatibility.

Well, apply patches downstream? I managed to do so with qtsingleapplication and falkon but it was about one or two methods only.

Comment 16 Raphael Groner 2020-07-22 14:13:46 UTC
new maintainer.


Note You need to log in before you can comment on or make changes to this bug.