Description of problem: Initial-setup fails on some hardware when there is no network connected. Version-Release number of selected component (if applicable): initial-setup-0.3.69-1.fc30.aarch64 anaconda-tui-30.25.6-1.fc30 How reproducible: Everytime Steps to Reproduce: 1. Boot a Pine 64 Plus with no network 2. Initial-setup fails Actual results: Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: Traceback (most recent call last): Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: File "/usr/lib/python3.7/site-packages/pydbus/registration.py", line 82, in call_method Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: result = method(*parameters, **kwargs) Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: File "/usr/lib64/python3.7/site-packages/pyanaconda/modules/network/network_interface.py", line 139> Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: self.implementation.create_device_configurations() Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: File "/usr/lib64/python3.7/site-packages/pyanaconda/modules/network/network.py", line 378, in creat> Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: self._device_configurations.reload() Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: File "/usr/lib64/python3.7/site-packages/pyanaconda/modules/network/device_configuration.py", line > Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: self.add_connection(connection) Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: File "/usr/lib64/python3.7/site-packages/pyanaconda/modules/network/device_configuration.py", line > Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: should_add, reason = self._should_add_connection(connection) Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: File "/usr/lib64/python3.7/site-packages/pyanaconda/modules/network/device_configuration.py", line > Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: iface = get_iface_from_connection(self.nm_client, uuid) Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: File "/usr/lib64/python3.7/site-packages/pyanaconda/modules/network/nm_client.py", line 50, in get_> Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: iface = get_iface_from_hwaddr(nm_client, mac) Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: File "/usr/lib64/python3.7/site-packages/pyanaconda/modules/network/nm_client.py", line 66, in get_> Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: if address.upper() == hwaddr.upper(): Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: AttributeError: 'NoneType' object has no attribute 'upper' Apr 12 15:19:02 localhost.localdomain org.fedoraproject.Anaconda.Modules.Network[1258]: INFO:pydbus.registration:name is not registered Apr 12 15:19:02 localhost.localdomain initial-setup[1049]: Initial Setup crashed due to unhandled exception: Traceback (most recent call last): File "/usr/libexec/initial-setup/initial-setup-text", line 10, in <module> is_instance.run() File "/usr/lib/python3.7/site-packages/initial_setup/__init__.py", line 342, in run self._initialize_network() File "/usr/lib/python3.7/site-packages/initial_setup/__init__.py", line 249, in _initialize_network network_proxy.CreateDeviceConfigurations() File "/usr/lib/python3.7/site-packages/pydbus/proxy_method.py", line 102, in __call__ raise error pyanaconda.modules.common.errors.DBusError: 'NoneType' object has no attribute 'upper' Expected results: No crash Additional info: Same error in anaconda when attempting an installation in beaker - https://bugzilla.redhat.com/show_bug.cgi?id=1699091
Nominating for dicussion as a possible blocker for F30 final.
Seems this would happen if device.get_hw_address or device.get_permanent_hw_address returned None. The code that actually crashes here has not changed since Feb 2018, but the path we reach it on - specifically the call to network_proxy.CreateDeviceConfigurations() - was added in initial-setup 0.3.67 in March 2019, as part of the fix for https://bugzilla.redhat.com/show_bug.cgi?id=1685992 , an earlier blocker in this cycle. anaconda itself also calls CreateDeviceConfigurations during network init, so in theory it could hit this too. I do wonder if something anaconda does *before* that filters out devices which would trigger this, but initial-setup doesn't do the same. I don't see anything *obvious* that does that, but there's some non-obvious stuff in there...
The obvious fix here is very simple, btw, it's just: -if address.upper() == hwaddr.upper(): +if address and address.upper() == hwaddr.upper(): but the more important question for right now is "why is this happening and how often is it likely to happen", since we need to know if we can ship RC1. That's what I'm trying to figure out.
anaconda-30.25.6-2.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7184d9d0c0
Discussed in the Fedora 30 Go/No-Go meeting blocker review: https://meetbot.fedoraproject.org/fedora-meeting-1/2019-04-25/f30-final-go_no_go-meeting.2019-04-25-17.01.log.html#l-562 This appears to hit a narrow case, but can't be fixed in an update. We defer a decision on blocker status
initial-setup works on kde with 30-1.2 x86_64
I don't have Pine 64 Plus, but on Raspberry Pi 3 the initial-setup works both with and without ethernet cable connected on images Fedora-{Minimal,Xfce}-armhfp-30-1.2
I hit this when trying to do a netinstall of F30 on my 2013 Macbook Pro, as there is no physical ethernet interface on the system, and the wireless card was not detected. I resolved the problem using a Wi-Pi usb adapter to get the install going. I can redownload the latest image and retest if required.
anaconda-30.25.6-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.