Bug 1715634 - must-gather does not include logs from pods in openshift-cluster-version namespace
Summary: must-gather does not include logs from pods in openshift-cluster-version name...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
urgent
high
Target Milestone: ---
: 4.2.0
Assignee: Abhinav Dahiya
QA Contact: sheng.lao
URL:
Whiteboard:
Depends On:
Blocks: 1717994 1721620
TreeView+ depends on / blocked
 
Reported: 2019-05-30 20:46 UTC by Abhinav Dahiya
Modified: 2019-10-16 06:29 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1717994 1721620 (view as bug list)
Environment:
Last Closed: 2019-10-16 06:29:26 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift must-gather pull 95 0 None None None 2019-06-05 13:30:03 UTC
Red Hat Product Errata RHBA-2019:2922 0 None None None 2019-10-16 06:29:43 UTC

Comment 1 David Eads 2019-05-31 13:01:51 UTC
The master team does not build collection information for individual operators or namespaces. It maintains an inspect command inside of must-gather that does heavy lifting for clusteroperators with related objects.

The clusterversionoperator must specify resources it wants collected inside of clusteroperator.status.relatedObjects if must-gather inspect is going to collect it.  

If the CVO is going to continue not having a clusteroperator (seems like a bug, but ok), you can work with Eric Rich to add to the script that CEE maintains in the must-gather repository.

Comment 2 Abhinav Dahiya 2019-05-31 16:34:49 UTC
So looking at the OWNERS for
cli: https://github.com/openshift/origin/tree/2819895745315df986ccb74016eb0106f49423b8/pkg/oc/cli/admin/mustgather
actual script: https://github.com/openshift/must-gather/blob/bb12f96da940bd0388ca94612a5d7b779a60b891/OWNERS#L6-L10

It seems like Master team does actually own this contrary to https://bugzilla.redhat.com/show_bug.cgi?id=1715634#c1

And must-gather fails to gather namespaces not part of ClusterOperator is not a bug in CVO, rather a bug in the gather command, because it decided to only look at status.relatedObjects for cluster operator, where it could have based the gather on `openshift` prefix for names etc..

Comment 3 David Eads 2019-05-31 16:49:43 UTC
Individual components are responsible for their own information gathering.  The master team started a repo to create an image that could be use for this purpose, created a generic command to cover the 80% case, started CEE on the path to describing collection, and took it through packaging, but we do not own the individual information gathering specific to non-standard components.

The inspect command covers use-cases for normal operators that simply need default actions.  If you need more than that (and it appears the CVO does since, it does not conform to the standard), you are responsible for adding it, the same way that the networking team is doing so.

Comment 4 Eric Rich 2019-06-05 13:45:53 UTC
https://github.com/openshift/must-gather/pull/95 should resolve this.

Comment 5 W. Trevor King 2019-06-05 14:21:31 UTC
#95 targets the master branch, so I'm moving back to ASSIGNED until we have a backport.

Comment 6 Eric Rich 2019-06-05 18:37:39 UTC
https://github.com/openshift/must-gather/pull/96 should be the PR for 4.1

Comment 7 W. Trevor King 2019-06-05 18:47:23 UTC
Not MODIFIED until the backport PR lands.

Comment 8 Eric Paris 2019-06-06 14:55:35 UTC
This pull was reverted. Do not violate process again.

Comment 9 Eric Paris 2019-06-06 14:55:53 UTC
https://github.com/openshift/must-gather/pull/97

Comment 11 Maciej Szulik 2019-06-24 09:28:10 UTC
*** Bug 1722966 has been marked as a duplicate of this bug. ***

Comment 13 sheng.lao 2019-06-25 09:13:19 UTC
Fixed in version: 4.2.0-0.nightly-2019-06-25-003324

# oc get pod -n openshift-cluster-version
NAME                                      READY   STATUS    RESTARTS   AGE
cluster-version-operator-875f79d4-hvfh4   1/1     Running   0          12m

# find |grep openshift-cluster-version
...
namespaces/openshift-cluster-version/pods/cluster-version-operator-875f79d4-hvfh4/cluster-version-operator/cluster-version-operator/logs/current.log
namespaces/openshift-cluster-version/pods/cluster-version-operator-875f79d4-hvfh4/cluster-version-operator/cluster-version-operator/logs/previous.log
...

Comment 14 Eric Rich 2019-07-18 18:58:55 UTC
*** Bug 1722966 has been marked as a duplicate of this bug. ***

Comment 16 errata-xmlrpc 2019-10-16 06:29:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2922


Note You need to log in before you can comment on or make changes to this bug.