Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1722966

Summary:	`oc adm must-gather` doesn't fetch information about the Release Image
Product:	OpenShift Container Platform	Reporter:	Alex Crawford <crawford>
Component:	oc	Assignee:	Sally <somalley>
Status:	CLOSED DUPLICATE	QA Contact:	Xingxing Xia <xxia>
Severity:	medium	Docs Contact:
Priority:	urgent
Version:	4.1.z	CC:	adahiya, aos-bugs, erich, jokerman, mmccomas, scuppett, tnozicka
Target Milestone:	---	Keywords:	Reopened
Target Release:	4.1.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-07-18 18:58:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alex Crawford 2019-06-21 20:53:43 UTC

Description of problem:

`oc adm must-gather` is supposed to provide enough detail about a running cluster for developers to debug the majority of failures. It currently collects the ClusterVersion object, which specifies a pull spec for the release image, but it doesn't collect anything about the release image itself. This is problematic when the customer creates a custom release image (`oc adm release new`) which is currently required for disconnected environments. 


Version-Release number of selected component (if applicable):

4.1.2


How reproducible:

Always


Steps to Reproduce:
1. Use `oc adm release new` to mirror a release to an alternate registry
2. Run `oc adm must-gather`

Actual results:

The ClusterVersion is captured in cluster-scoped-resources/config.openshift.io/clusterversions/version.yaml, but this isn't enough information to determine whether or not any functional changes were made to the release image when mirroring.


Expected results:

`oc adm must-gather` also collects all of the top-level manifests and release metadata (e.g. the output of `oc adm release extract`).


Additional info:

Comment 1 Maciej Szulik 2019-06-24 09:28:10 UTC

This looks like a duplicate of bug 1715634 which is already addressed in master https://github.com/openshift/must-gather/pull/95
although the 4.1 was reverted due to lack of approval from architects.

*** This bug has been marked as a duplicate of bug 1715634 ***

Comment 2 Alex Crawford 2019-06-25 22:48:41 UTC

I see namespaces/openshift-cluster-version collected by must-gather, but I don't see anything in there that's going to help me answer my question: what is this cluster running? The customer has made their own release image, but have they kept everything in tact or did they tweak things in the process.

Comment 3 Maciej Szulik 2019-06-27 21:33:33 UTC

What kind of information you'd expect to be gathered, in that case?

Comment 4 Abhinav Dahiya 2019-07-10 18:20:03 UTC

I would expect us to gather the results of

```
## generic information
oc adm release info
## details information about the commits
oc adm release info --commits
## details information about the pullspecs or images in the release image
oc adm release info --pullspecs
## the contents of the release image
oc adm release info --contents
```

Comment 7 Eric Rich 2019-07-18 18:54:05 UTC

(In reply to Abhinav Dahiya from comment #4)
> I would expect us to gather the results of
> 
> ```
> ## generic information
> oc adm release info
> ## details information about the commits
> oc adm release info --commits
> ## details information about the pullspecs or images in the release image
> oc adm release info --pullspecs
> ## the contents of the release image
> oc adm release info --contents
> ```

Why do we need to gather this if we know the release version? Can't we get all this locally (from a pulled image ourself)?

Comment 8 Eric Rich 2019-07-18 18:58:55 UTC


*** This bug has been marked as a duplicate of bug 1715634 ***

Comment 9 Eric Rich 2019-07-18 18:59:59 UTC


*** This bug has been marked as a duplicate of bug 1717994 ***

Comment 10 Abhinav Dahiya 2019-07-18 19:32:25 UTC

(In reply to Eric Rich from comment #7)
> (In reply to Abhinav Dahiya from comment #4)
> > I would expect us to gather the results of
> > 
> > ```
> > ## generic information
> > oc adm release info
> > ## details information about the commits
> > oc adm release info --commits
> > ## details information about the pullspecs or images in the release image
> > oc adm release info --pullspecs
> > ## the contents of the release image
> > oc adm release info --contents
> > ```
> 
> Why do we need to gather this if we know the release version? Can't we get
> all this locally (from a pulled image ourself)?

For disconnected customers the release-image being used is not accessible from the public, how will we pull from that specific image from outside?

Comment 11 Eric Rich 2019-07-18 19:39:23 UTC

(In reply to Abhinav Dahiya from comment #10)
> (In reply to Eric Rich from comment #7)
> > (In reply to Abhinav Dahiya from comment #4)
> > > I would expect us to gather the results of
> > > 
> > > ```
> > > ## generic information
> > > oc adm release info
> > > ## details information about the commits
> > > oc adm release info --commits
> > > ## details information about the pullspecs or images in the release image
> > > oc adm release info --pullspecs
> > > ## the contents of the release image
> > > oc adm release info --contents
> > > ```
> > 
> > Why do we need to gather this if we know the release version? Can't we get
> > all this locally (from a pulled image ourself)?
> 
> For disconnected customers the release-image being used is not accessible
> from the public, how will we pull from that specific image from outside?

Disconnected customer will pull a mirrored image (those image details will be accessible to us). - If customers are running a modified release image (it's not supported).