Spec Name or Url:http://apt.kde-redhat.org/apt/kde-redhat/SPECS/apollon-1.0.1-1.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/apollon-1.0.1-1.src.rpm Description: A filesharing client which uses giFT.
See also previous livna review/comments: http://bugzilla.livna.org/show_bug.cgi?id=233
Needs work: * The package should contain the text of the license (wiki: PackageReviewGuidelines) * The package contains a libtool archive file (wiki: PackagingGuidelines#StaticLibraries) Apollon seems to work without it.
%changelog * Mon Dec 19 2005 Rex Dieter <rexdieter[AT]users.sf.net> 1.0.1-2 - more %%doc's: AUTHORS ChangeLog COPYING TODO - drop %%_libdir/lib*.la Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/apollon-1.0.1-2.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/apollon-1.0.1-2.src.rpm
missing BuildRequires: libacl-devel
libacl-devel shouldn't be necessary. Or is this a manifestation of bug #170602 "Remove references to -lacl (and others) in .la files"? (I assume you're seeing this on fc4? If so, I'll reopen the bug)
Yes, this is in an FC4 chroot via mock.
%changelog * Tue Dec 20 2005 Rex Dieter <rexdieter[AT]users.sf.net> 1.0.1-3 - BR: libacl-devel (workaround kdelibs bug #170602) Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/apollon-1.0.1-3.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/apollon-1.0.1-3.src.rpm
Review for release 3: * RPM name is OK * Source apollon-1.0.1.tar.bz2 is the same as upstream * This is the latest version * Builds fine in mock * rpmlint of apollon looks OK * File list of apollon looks OK * Works APPROVED