Bug 1758353 - undercloud.conf default values provide insufficient range for ctlplane-subnet
Summary: undercloud.conf default values provide insufficient range for ctlplane-subnet
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-tripleo-validations
Version: 13.0 (Queens)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: z11
: 13.0 (Queens)
Assignee: Bob Fournier
QA Contact: nlevinki
URL:
Whiteboard:
Depends On:
Blocks: 1715822 1764260 1764310
TreeView+ depends on / blocked
 
Reported: 2019-10-03 21:44 UTC by Thom Carlin
Modified: 2020-03-10 11:22 UTC (History)
8 users (show)

Fixed In Version: openstack-tripleo-validations-8.5.0-3.el7ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1764260 1764310 (view as bug list)
Environment:
Last Closed: 2020-03-10 11:22:02 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1848498 0 None None None 2019-10-17 12:51:17 UTC
OpenStack gerrit 690136 0 'None' MERGED Set validation defaults to match undercloud default settings 2020-04-27 14:18:35 UTC
Red Hat Bugzilla 1758349 0 unspecified CLOSED Pre-introspection 'ctlplane-ip-range' check needs to account for default values 2021-02-22 00:41:40 UTC
Red Hat Product Errata RHBA-2020:0760 0 None None None 2020-03-10 11:22:53 UTC

Description Thom Carlin 2019-10-03 21:44:17 UTC
Description of problem:

In undercloud.conf, [ctlplane-subnet] the default values for dhcp_start/dhcp_end do not provide enough IP addresses to pass tripleo validation

Version-Release number of selected component (if applicable):

13-z

How reproducible:

100%

Steps to Reproduce:
1. Configure undercloud.conf per Director Installation and Usage guide
OR Examine  /usr/share/instack-undercloud/undercloud.conf.sample 
2. Examine /usr/share/openstack-tripleo-validations/validations/ctlplane-ip-range.yaml
3. Run ctlplane-ip-range validation

Actual results:

1. contents:
[...]
[ctlplane-subnet]
[...]
#dhcp_start = 192.168.24.5
#dhcp_end default = 192.168.24.24
[...]
2. contents
[...]
ctlplane_iprange_min_size: 25
[...]
3. logfile:
[...]
TASK [Check the size of the DHCP range for overcloud nodes] ********************
fatal: [undercloud]: FAILED! => {"changed": false, "msg": "The IP range 192.168.24.5 - 192.168.24.24 contains 20 addresses.\nThis might not be enough for the deployment or later scaling."}
[...]
PLAY RECAP *********************************************************************
undercloud                 : ok=4    changed=0    unreachable=0    failed=1  

Expected results:

1. contents:
[...]
[ctlplane-subnet]
[...]
#dhcp_start = 192.168.24.5
#dhcp_end default = 192.168.24.29
[...]
2. contents
[...]
ctlplane_iprange_min_size: 25
[...]
3. logfile contents:
[...]
TASK [Check the size of the DHCP range for overcloud nodes] ********************
ok: [undercloud]

PLAY RECAP *********************************************************************
undercloud                 : ok=5    changed=0    unreachable=0    failed=0   


Additional info:

See also https://bugzilla.redhat.com/show_bug.cgi?id=1758349
and https://docs.openstack.org/tripleo-validations/queens/validations-pre-introspection-details.html#ctlplane-ip-range

Comment 2 Bob Fournier 2019-10-08 13:07:06 UTC
Is this a new validation that requires a minimum of 25 addresses?  The range of 20 addresses (192.168.24.5-192.168.24.24) has always been what is used for the default in undercloud.conf, its adequate for small scale setups but will obviously require adjustment in larger deployments.

Recommend changing the validation to a minimum size of 20 instead of 25.

Comment 3 Bob Fournier 2019-10-15 20:42:27 UTC
Checking with UI team if this validation default can be changed?

Comment 4 Cédric Jeanneret 2019-10-16 06:07:54 UTC
Heya!

I'm not UI (although working on validations ;) - DF here), but I tend to think we should get HardProv feedback on that. 20 IPs might be enough, but 25 aren't that big a range either.
The validation isn't new afaik, but it's a new thing that users are actually using it.

But I'm pretty sure changing the default requirement in the validation will be faster/easier than changing all the references to the "too small" range.

Who can we ask within HardProv for confirmation/feedback?

Cheers,

C.

Comment 5 Bob Fournier 2019-10-16 11:35:51 UTC
>I tend to think we should get HardProv feedback on that. 20 IPs might be enough, but 25 aren't that big a range either.
>The validation isn't new afaik, but it's a new thing that users are actually using it.

The default range of 20 addresses in undercloud.conf can be changed during the undercloud install and that's the recommended practice, however for a POC this number is adequate.  The validation should also be using 20 (not 25) as it shouldn't be more than the default and enforcing this higher limit will cause problems with all existing deployments that use the default.

Comment 7 Cédric Jeanneret 2019-10-17 06:08:15 UTC
Thank you for your feedback, Bob.
Do you take care of the LP for the upstream backports as well as BZ clones for downstream backports? Do you need any help on doing those actions?

Cheers,

C.

Comment 8 Bob Fournier 2019-10-17 12:51:17 UTC
Cedric - yes I'll do the clones and backports (downstream and usptream).

Comment 9 Bob Fournier 2020-01-21 20:50:13 UTC
It looks like the patch had been backported downstream but a build had not been done.  Built pkg and moving to MODIFIED,

Comment 12 errata-xmlrpc 2020-03-10 11:22:02 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0760


Note You need to log in before you can comment on or make changes to this bug.