Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1769008

Summary: Missing openapi CRD definitions for oc explain to work
Product: OpenShift Container Platform Reporter: Maciej Szulik <maszulik>
Component: Image RegistryAssignee: Ricardo Maraschini <rmarasch>
Status: CLOSED ERRATA QA Contact: Wenjing Zheng <wzheng>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.3.0CC: adam.kaplan, aos-bugs, bparees, rmarasch, wzheng, xiuwang
Target Milestone: ---   
Target Release: 4.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1785302 (view as bug list) Environment:
Last Closed: 2020-05-04 11:14:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1769621, 1785302    

Description Maciej Szulik 2019-11-05 18:18:03 UTC
The following PR https://github.com/openshift/origin/pull/22696 introduced an e2e which is verifying that all the operators provide descriptive information as part of their schema which is then available through oc explain command. 
This was recently updated and brought back in https://github.com/openshift/origin/pull/24058. 

Your component has a few missing bits, see the commented out lines from the PR.

This should be fixed similarly to https://github.com/openshift/cluster-kube-controller-manager-operator/pull/302, 
iow. it should be using openshift/api's generated CRD yamls. 

Once done update origin's e2e test and uncomment the lines from your components.

Comment 2 Adam Kaplan 2019-11-12 14:00:51 UTC
*** Bug 1769621 has been marked as a duplicate of this bug. ***

Comment 4 Adam Kaplan 2019-11-22 18:35:31 UTC
API changes landed in 4.3, but client-go has not landed yet.

@Ricardo at this point it may be easier to keep the existing client in the image registry operator repo, and merely regenerate it by bumping openshift/api. Keep in mind that we will want to backport this change to the release-4.3 branch.

Comment 7 Wenjing Zheng 2019-12-16 08:12:34 UTC
[wzheng@openshift-qe 4.4]$ ./oc version
Client Version: v4.4.0
Server Version: 4.4.0-0.nightly-2019-12-15-184910
Kubernetes Version: v1.16.2
[wzheng@openshift-qe 4.4]$ ./oc explain configs --api-version=imageregistry.operator.openshift.io/v1
KIND:     Config
VERSION:  imageregistry.operator.openshift.io/v1

DESCRIPTION:
     <empty>
[wzheng@openshift-qe 4.4]$ ./oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.4.0-0.nightly-2019-12-15-184910   True        False         6h55m   Cluster version is 4.4.0-0.nightly-2019-12-15-184910

I still cannot see the fix, so assign back.

Comment 9 XiuJuan Wang 2019-12-25 01:18:43 UTC
Test with 4.4.0-0.nightly-2019-12-20-210709 payload, and pass
$oc version 
Client Version: v4.3.0
Server Version: 4.4.0-0.nightly-2019-12-20-210709
Kubernetes Version: v1.17.0

$oc explain configs --api-version=imageregistry.operator.openshift.io/v1
KIND:     Config
VERSION:  imageregistry.operator.openshift.io/v1

DESCRIPTION:
     Config is the configuration object for a registry instance managed by the
     registry operator

FIELDS:
   apiVersion	<string>
     APIVersion defines the versioned schema of this representation of an
     object. Servers should convert recognized schemas to the latest internal
     value, and may reject unrecognized values. More info:
     https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources

   kind	<string>
     Kind is a string value representing the REST resource this object
     represents. Servers may infer this from the endpoint the client submits
     requests to. Cannot be updated. In CamelCase. More info:
     https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds

   metadata	<Object> -required-
     Standard object's metadata. More info:
     https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata

   spec	<Object> -required-
     ImageRegistrySpec defines the specs for the running registry.

   status	<Object>
     ImageRegistryStatus reports image registry operational status.

Comment 11 errata-xmlrpc 2020-05-04 11:14:43 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0581